department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Implement changes to Experience Standards based on Pilot findings #70958

Closed shiragoodman closed 7 months ago

shiragoodman commented 11 months ago

User Story

As a Governance Team member, I want to make changes to our Experience Standards and Staging Review to streamline processes for VFS teams going through the collab cycle.

As a VFS team member, I want to better understand and be able to act on findings from Staging Reviews.

Assignee: @erinrwhite @rferguson13 Peer Reviewer: @briandeconinck

Description

Recommended changes based on pilot findings

Impacted Artifacts

Tasks

Peer Review

To be completed by peer reviewer

Acceptance Criteria

Team Notification

How to prepare this issue

Refinement

erinrwhite commented 7 months ago

Updated tasks list based on synthesis in #78211 and #78212

shiragoodman commented 7 months ago

Thank you for this @erinrwhite ! Would you mind if I scheduled a 1:1 sync with you to discuss the tasks in this ticket? I want to make sure I fully understand your recommendations before pulling this work into our next sprint.

erinrwhite commented 7 months ago

@shiragoodman yes that sounds like a good idea! There is a lot here 😂

shiragoodman commented 7 months ago

@erinrwhite I have updated this ticket, and checked off the few items where tickets have already been created and/or the work will be handled outside of the initiative (aka post-launch as tech-debt). Let me know if you have any questions or concerns.

PS I used the convert tasks to issues option for #79479 and then changed the name of the ticket, however your original comments can be found in the ticket history.

erinrwhite commented 7 months ago

Quick divvy up of tasks with @rferguson13

erinrwhite commented 7 months ago

@rferguson13 Started our "lightweight mechanism" aka page in confluence - I feel like the headers can be clearer. Can you take a look when you have a minute?

erinrwhite commented 7 months ago

Updates to Drafting Templates ready for review when you have some moments, @briandeconinck - these are copies of the drafting templates, not the live versions:

Changes

Findings tab

GitHub upload tab

erinrwhite commented 7 months ago

Per conversation with @shiragoodman we are going to absorb the below task in this epic to improve Midpoint and Staging, rather than as part of this ticket. 🎉 @rferguson13

Encourage teams to share limitations/scope constraints of their projects at staging review.

shiragoodman commented 7 months ago

Just noting that I think this page will also need to be updated based on some of our post-pilot changes. FYI @erinrwhite @rferguson13

erinrwhite commented 7 months ago

@shiragoodman @rferguson13 Anatomy of a staging review ticket draft page updated!

briandeconinck commented 7 months ago

@erinrwhite All of those Drafting Template changes look good to me!

erinrwhite commented 7 months ago

@rferguson13 @briandeconinck Updated our How to Add Images or Videos to Staging Review findings tickets and also updated the page name; ready for review. I am also making sure our internal links to this page are still working with the URL change.

erinrwhite commented 7 months ago

Thank you for the review, @briandeconinck - I went ahead and moved the Drafting Template changes into production (replaced the existing files), and updated the "backups" folder with this new version as well. @rferguson13

erinrwhite commented 7 months ago

Status update Friday 4/5 - after sync with @rferguson13! @briandeconinck @shiragoodman

In progress:

Ready for review

Done - published

rferguson13 commented 7 months ago

Ok @briandeconinck ! As well as Erin's review above, I've got a couple of things ready for you:

briandeconinck commented 7 months ago

@rferguson13 Besides Matt's comment on component/pattern labels, I only have one minor piece of feedback.

In the Anatomy of a Staging Review ticket example screenshots, the Product Information section is:

Team: Testing team Product: Testing product Feature: Testing feature

The first time I read it, I was confused about what "Testing team" meant here --- will a real ticket say Team: Governance team since we're the team doing the staging review testing? Or will it say Team: Veteran Facing Forms or whatever the team is coming through the Collab Cycle?

Once you get actual live findings tickets, that will become clear immediately. But for a new VFS team / PM who's on this page trying to understand the process, I think using the word "Testing" here is a potential point of confusion. I'm guessing you were trying to keep it generic to avoid the appearance of calling out a VFS team, but I wonder if there's a better way to phrase it.

Otherwise I think all of this looks great!

rferguson13 commented 7 months ago

@briandeconinck - That's a good point. Do you think it can be solved by adding more detail to that section? E.g. "This section contains information like the team’s name, the product name, and the feature." Or should I redo the screen shots?

briandeconinck commented 7 months ago

I feel like redoing the screenshots would be worth it, but I know I'm a monster for saying that! 😀

rferguson13 commented 7 months ago

@briandeconinck Thanks to your wizardry, this page is now done. Can you take another look?

rferguson13 commented 7 months ago

@erinrwhite - For visibility. We're just wrapping up the peer review. Once @briandeconinck gives the thumbs up, I think we're good to go. Correct me if I'm wrong, but we're not publishing these yet, right? Not until we officially publish the new standards next sprint.

briandeconinck commented 7 months ago

Ooh, right, that's my cue to give you my thumbs up: 👍

shiragoodman commented 7 months ago

@rferguson13 correct - we're not publishing yet. That happens soon tho! 🎉