Create isolated version of MHV Landing page app

dcloud commented 11 months ago

Description

Per [EPIC]: Move landing page to isolated app build #70837, we want to opt in to app isolation. To do this for an existing app, we need to create a new copy of the app in vets-website while temporarily preserving the non-isolated version.

The non-isolated version should exist until the content-build repo registers the isolated app and we are confident that the non-isolated version is no longer part of the build process.

User story

As a Cartographers team member, I want our landing page to be built in isolation, so that deploys are done quickly and on-demand with less exposure to unrelated flaky CI steps.

Acceptance criteria

A "copy" of the landing page exists at a top-level app location, e.g. src/applications/mhv-landing-page. Maybe git mv to preserve git history?
The "original" non-isolated copy exists at the old location until isolated version builds. We don't want content-build to choke on a missing app path.
Work on deploy, verify, cleanup is assigned, begun. This is the "swap old for new" step

Tasks

[x] Create copy of code at src/applications/mhv-landing-page, preferably using git mv
[x] Ensure copy of code still exists at src/applications/mhv/landing-page
[x] Add CODEOWNERS entry for src/applications/mhv-landing-page
[x] Copy medications landing page code (and dependencies) into the new MHV landing page location
[x] Opt in to app isolation, clean up dependencies. Hint: yarn check-app-imports --app-folders mhv-landing-page

dcloud commented 11 months ago

If this move, then isolate PR works (and it seems to), then we may need fewer PRs than previously thought

dcloud commented 11 months ago

The medications team introduced breaking changes before our work could be merged, so this sets us back some time

dcloud commented 11 months ago

Marking this as blocked since multiple updates to the medications landing page were made, which blocks our "temporarily adopt medications about page" approach, and thus app isolation

dcloud commented 10 months ago

Progress:

Medications team has adopted landing page: Merged PR, https://jira.devops.va.gov/browse/MHV-52782
Redirect in place: https://github.com/department-of-veterans-affairs/devops/pull/13813
They also opened a PR to remove their code from our app: https://github.com/department-of-veterans-affairs/vets-website/pull/27227

I've confirmed the server-side redirect in staging, and saw the page at /my-health/medications/about, so that seems good.

Next step is to update https://github.com/department-of-veterans-affairs/vets-website/pull/27001 or create a new PR to isolate the app. Probably easier to start fresh given all the changes that create merge conflicts

department-of-veterans-affairs / va.gov-team