department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

[a11y-defect-2]: Edit & Remove buttons do not have distinct aria-labels #71635

Closed jeana-adhoc closed 10 months ago

jeana-adhoc commented 10 months ago

Point of contact

@jeana-adhoc

Severity level

2, Serious. Should be fixed in 1-2 sprints post-launch.

Details

On the disability exam page, when there are multiple edit and remove buttons on the page, aria-labels must be added to the buttons and be made unique so that you know what is being edited.

Reproduction steps

  1. Enable a screen reader
  2. Navigate to the disability exam page
  3. Add 2 or more exam dates
  4. Go back and click "Edit" You will hear "Edit exam date" for each card.

Proposed solution or next steps

The aria-label for each edit button should be "Edit exam date for actual exam date" And include the actual date that is being edited.

The aria-label for each remove button should be "Remove exam date for actual exam date" And include the actual date that is being edited.

References, articles, or WCAG support

  1. WCAG2.1 Understanding Success Criterion 2.5.3: Label in Name

Type of issue

tlei123 commented 10 months ago

PR opened.

tlei123 commented 10 months ago

PR merged — changes should be in Staging by ~4:45 PM ET.

tlei123 commented 10 months ago

@tbaker1026 @jeana-adhoc @rachelshearerux , fix is now in Staging, ready for validation.

jeana-adhoc commented 10 months ago

This works great!! Verified in staging. Edit and remove buttons aria-labels include the date making them unique.