Design + FE | Profile | Maintenance | Make bottom margin consistent between sections across profile pages

[andaleliz]

Background

The account security and connected apps pages have 16px of bottom margin between <section> elements, contact information has 48px, and direct deposit has 32px. Military info has no bottom margin declared on the section, which makes sense since it's all in one card (for now).

This is reflected in staging (and presumably prod) for sure. The design files are a mixed bag of whether or not they have 32px or what is actually reflected on staging.

We should figure out how much spacing we want between sections on desktop and mobile, and make sure it's consistent across all the pages. Based on the design files, it seems that 32px was the intention, but maybe we want to consider decreasing that in favor of a shorter page.

Tasks

• [ ]

AC

• [ ] Spacing is consistent on the website and design files across the pages listed above.

[andaleliz]

@mtcA6 I noticed this as part of migrating the Sketch files. I purposely combined practice areas in the ticket because it's a good opportunity to collaborate, and I've been thinking it might be interesting to try a combined approach to tickets to see how it impacts our work and team flow. If you prefer to do it the way we normally do, that's cool with me. Just wanted to capture this in a ticket before I forget.

IMO this can be a low priority backlog "pick up as people have time" sort of project.

[mtcA6]

@adamwhitlock1 will migrating to the new components resolve this ticket?

[adamwhitlock1]

Migration to the new components will no affect these margins, so this ticket will still be needed.