department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Epic: Fix the build to use dart-sass (unblock node upgrade) #72830

Open caw310 opened 10 months ago

caw310 commented 10 months ago

Status

Update each sprint until completed Date Status Launch Date (see above) Notes
17 Oct in-progress on-track work in progress

Problem Statement

vets-website is currently using node-sass v4.14.1. node-sass is currently a deprecated dependency. We need to move onto Dart Sass. vets-website needs to make this upgrade because it is blocking the upgrade of the node engine (currently set to 14.15.0).

Hypothesis or Bet

How will this initiative impact the quality of VFS or Platform teams' work? How will this initiative be easy for VFS or Platform teams? Or how will it be easier than what they did before? Unblocking the node upgrade will remove the dependency on a deprecated version of node.

We will know we're done when... ("Definition of Done")

What requirements does this project need to meet for you to finish this initiative?

Known Blockers/Dependencies

List any blockers or dependencies for this work to be completed

Projected Launch Date

FY Q4 2024

humancompanion-usds commented 1 month ago

This issue is blocked by Formation deprecation.

humancompanion-usds commented 1 month ago

@micahchiang has a PR going that would update us to a specific version of dart-sass and unblock the node upgrade.

humancompanion-usds commented 1 month ago

Adrian forked a branch off of Micah's original branch. Adrian resolved the networking issue for Cypress. Curt noticed there was a unit test stress test silent failure. Failing on a node child process. He's going to dedicate time to that this week. But Curt is also in the path of the hurricane. Targeting 11/11 to have this done.