department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

[CI/CD]: Review coverage of accessibility checks in EDU apply-wizard end-to-end tests #7350

Open 1Copenut opened 4 years ago

1Copenut commented 4 years ago

Feedback framework

Description

Applications must have thorough end-to-end tests that run in our continuous integration/continuous deployment (CI/CD) pipeline. These tests should include thorough axe checks. While auditing the /edu-benefits/edu-apply-wizard folder, I noticed we should be calling the axe check after all radio buttons have been checked and the entire wizard is shown. I'd like the front-end engineering team to review the applications, and update the tests to review this hidden content. Definition of done in acceptance criteria below.

Point of Contact

VFS Point of Contact: Trevor

Environment

Acceptance Criteria

Definition of done:

WCAG or Vendor Guidance (optional)

1Copenut commented 3 years ago

@mattpointzxer0 If the team has moved to use the Cypress forms testing, would you mind commenting here and at include me? The Cypress forms tester has axe checks built in and would be a good way to close this issue without additional work.