rmtolmach
commented
8 months ago Prefill for contact_information is used in most of the forms. For example in config/form_profile_mappings/10-10EZR.yml
homePhone: [contact_information, us_phone]
veteranAddress: [contact_information, address]
email: [contact_information, email]contact_information is initialized in form_profile.rb
def initialize_contact_information
opt = {}
opt.merge!(vets360_contact_info_hash) if vet360_contact_info
opt[:address] ||= user_address_hash
opt[:email] ||= extract_pciu_data(:pciu_email)
if opt[:home_phone].nil?
opt[:home_phone] = pciu_primary_phone
opt[:us_phone] = pciu_us_phone
end
...vets-api has been getting contact information from VA Profile for a few years now, so that's good /lib/va_profile/contact_information.
LindseySaari
jennb33
Issue Description
To prepare for the eventual sunsetting of EVSS, all calls to PCIU must eventually be removed from vets-api. During the course of discovery for Form526ez, it was discovered that calls to PCIU were being made in the FormProfile base-class related to the Pre-fill functionality- specifically to gather phone and email information. While Form526ez and many other forms intentionally use it in combination with their own derived Pre-fill classes, further digging through vets-api and in DataDog revealed that essentially every form in the system was calling out to PCIU. Either way, it became apparent that the scope of the problem was beyond just Form526ez.
The good news is that the base-class pre-fill is already calling out to VA Profile, which is widely considered the best one-stop source of all contact information within the VA. The specific reason we call out to PCIU here at all remains a mystery, although the best educated guess so far suggests that it may have to do with a potential lag between the time that the user enters/updates information and the time when it becomes available in VA Profile. In other words, if a user just updated their information and went straight to an application that uses Pre-fill, that information might not prefill in that application's form. This is just speculation, however, and there's a chance that if it WAS a problem when they added the PCIU calls 4-6 years ago, that latency might not be an issue anymore.
A potential strategy for the Platform Team (who likely owns this code) or whoever is tagged to implement/orchestrate the change):
Acceptance Criteria
Related Docs
OCTO Objectives:
Objective: This aligns with O2: Our platforms are the best way to deliver products at VA OKR This aligns with OKR1: Our platforms hit the "elite" level (as defined by DORA) on Deployment Frequency, Lead Time for Changes, Change Failure Rate, and Time to Restore Service.
Previous Epic
Future Initiative