department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Shared code | Update to use USWDS v3 components #73827

Closed Mottie closed 6 months ago

Mottie commented 9 months ago

Value Statement

As a Benefits Decision Reviews team member I want to make sure we're updating all of our forms to use USWDS v3 components & styles So that Veteran's can get a consistent experience across our forms

Background Context

The design system team made this announcement today:

On February 16 all design system web components will default to their v3 variant. v3 will become opt out only. In one month, the design system team will be switching all web components to render their v3 variant automatically. If teams have a need to fall back to the original v1 variant, they will be able to do so by setting the uswds prop to false. However, v1 variants will eventually be fully retired and removed so opting out is discouraged.

So our team needs to evaluate and update styles & components within our Decision Reviews forms to match the USWDS v3 styles.

Tasks

Acceptance Criteria

Definition of Ready

Definition of Done

Mottie commented 8 months ago

Available for testing in staging

saderagsdale commented 8 months ago

@Mottie How would we test this to confirm nothing is broken? Does it have any impact on code coverage?

eileen-coforma commented 8 months ago

@rocio-desantiago @Mottie The 'progress-bar-segmented' on the form seems like it's still v1, not v3.

rocio-desantiago commented 8 months ago

@rocio-desantiago @Mottie The 'progress-bar-segmented' on the form seems like it's still v1, not v3.

Correct. There are parts of the form that will still be V1 until form systems update to V3.

saderagsdale commented 8 months ago

@saderagsdale will ask Matt Dingee about acceptance criteria for this.

HeatherWidmont commented 8 months ago

Did get a response about what exactly they're looking for. @saderagsdale will add that as the AC & use that as a gauge what needs to change

HeatherWidmont commented 8 months ago

Team to review in parking lot today