department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
280 stars 195 forks source link

[Link and button labels] Button and link language isn't descriptive and/or their purpose isn't clear. (08.03.1) #73969

Closed shiragoodman closed 4 months ago

shiragoodman commented 5 months ago

General Information

VFS team name

Pension Benefits Team

VFS product name

Pension 527EZ Digital Form

VFS feature name

Form Reactivation

Point of Contact/Reviewers

Brian DeConinck - @briandeconinck - Accessibility

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Button and link language isn't descriptive and/or their purpose isn't clear.

Issue Details

On Other service names, when answering "yes" to "Did you serve under another name?" a list-and-loop pattern is revealed. When a user enters multiple names, the Edit button for each entry doesn't have a unique accessible name. Each has an aria-label of "Edit name," meaning a screen reader user won't know what name they're editing without exploring the surrounding context.

The same issue occurs on:

Link, screenshot or steps to recreate

VA.gov Experience Standard

Category Number 08, Issue Number 03

Other References

WCAG SC 2.4.4_A

Platform Recommendation

Recommend making the Edit button's aria-label something like Edit [first last] to make each one unique (or at least unique-ish, since a user could enter a name multiple times).


VFS Guidance

vbellissimo commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @danlim715 @scottsdevelopment @TaiWilkin @ToddWebDev @wayne-weibel

aplatt-coforma commented 4 months ago

@gmaciolek - could you please validate this change in staging tomorrow morning? It's already on it's way to PROD so I'll go ahead and close it for the sprint.