department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
280 stars 195 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.5) #73980

Closed shiragoodman closed 3 months ago

shiragoodman commented 5 months ago

General Information

VFS team name

Pension Benefits Team

VFS product name

Pension 527EZ Digital Form

VFS feature name

Form Reactivation

Point of Contact/Reviewers

Brian DeConinck - @briandeconinck - Accessibility

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

On Gross monthly income, when you select "Other income," a follow-up field is revealed. The label on that conditionally-revealed field just says "Please specify," which isn't a label that can be understood on its own.

Updated Figma Designs

The Figma design for this page has been updated with these changes.

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

Use the approved design components/patterns. If you feel your feature needs something different, you will need to propose a solution, validate it through usability testing, and document the results.

Platform Recommendation

See the design system guidelines on conditionally revealed inputs:

The newly revealed question field must be understood by itself. For example, don’t just say “Other”. Say, “Since your relationship with the veteran was not listed, please describe it here”


VFS Guidance

katherine-fung commented 5 months ago

Recommended copy to replace "Please specify"

Tell us the type of income.

[Additional request: Please tweak the question "What type of income?" to "What type of income do you, your spouse, or your dependents receive?"]

gmaciolek commented 3 months ago

The Figma design for this page has been updated with these changes.

aplatt-coforma commented 3 months ago

Moving to Product Backlog for refinement. cc @buddhima-coforma @matt4su

aplatt-coforma commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @danlim715 @mjknight50 @scottsdevelopment @TaiWilkin @ToddWebDev @wayne-weibel

ToddWebDev commented 3 months ago

@gmaciolek Please review this ticket in github and on stage and update the 'Please specify' fields in marriages and spouse marriages in Figma so that it is in sync. Please let me know if you have any questions abou the additional changes.