department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 201 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.1) #73984

Closed shiragoodman closed 4 months ago

shiragoodman commented 8 months ago

General Information

VFS team name

Pension Benefits Team

VFS product name

Pension 527EZ Digital Form

VFS feature name

Form Reactivation

Point of Contact/Reviewers

Allison Christman - @allison0034 - Design

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

This form uses quite a few multiple response patterns. The pattern used in this form is not styled correctly (missing gray card background/card component and save button). There are also some alignment issues on the left side of the form. I have noted this pattern on these pages:VA medical centers, Federal medical facilities, Spouse’s former marriage, Dependent children, Gross monthly income and Add an unreimbursed care expense pages.

Link, screenshot or steps to recreate

Screen shot care expense, Screen shot gross monthly income, screen shot spouse marriage, screens shot dependent children, screen shot current employment, screen shot VA medical centers, screen shot other service names

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

Use the approved design components/patterns. If you feel your feature needs something different, you will need to propose a solution, validate it through usability testing, and document the results.

Platform Recommendation

Look at the flow and UI of the multiple responses pattern in the design system. We currently have 2 types, single page and multi page. Use the single page multiple responses pattern with short data sets and the multi page pattern with longer data sets. Review the guidance for more information. Be sure to follow the UI for each pattern. Also, check the left text alignment.


VFS Guidance

aplatt-coforma commented 4 months ago

These issues have been addressed with the ticket #79329. Closing this ticket cc @matt4su @buddhima-coforma

DependentChildren.png VAMedicalCenters.png SpouseFormerMarriages.png CurrentEmployeement.png OtherServiceNames.png CareExpenses.png GrossMonthly.png