Closed 1Copenut closed 4 years ago
Design comments:
Research Plan
Implementation feedback that cannot be reflected in designs
checked
radio buttons do not read as checked to me. There's no center to the "bullseye" and despite the reversed color scheme, I'm not confident I've done everything right. Should be tested closely with users to ensure they understand this is the checked
state.
Left ear only
and Both ears
headings on both pages. It was confusing why those appeared in some views but not others.
Thanks so much for the detailed acknowledgement! I appreciate the collaborative conversation. 😄
- Headings inside of the alert boxes are standardized, right? Is the correct treatment utility classes?
Yes, utility classes would be the preferred approach.
https://vsateams.invisionapp.com/share/6MVTG94WNH5#/screens/406054376 and https://vsateams.invisionapp.com/share/6MVTG94WNH5#/screens/407889090 have an interesting hierarchy challenge. Would it make sense to remove the heading "Add batteries to your order" and just lead with the alert box "None of your devices are eligible for battery resupply" ? If this is the guidance, we can do it. It made sense in my mind to have the title of the page shown as it states the purpose of the page, even if they're not able to currently eligible to use it. Maybe @jenstrickland can also cast a vote if you're on the fence.
Yes, if it's possible, to streamline those headings so that they read:
@jenstrickland @1Copenut Alrighty, made that last change and removed the titles!
Thanks! Good luck with testing!
Feedback framework
VSA Feedback
Comments provided in Invision.
Research Plan
Definition of Done
VSP Feedback
Must
<label>
and<input type="radio">
elements. All users should be able to understand these things have a relationship and it's one or the other.<Alert/>
box instead, and that's going to need careful testing with assistive tech users. We need that non-selectable element to do a few things:<input type="checkbox" disabled />
should do the trick.Should
checked
radio buttons do not read as checked to me. There's no center to the "bullseye" and despite the reversed color scheme, I'm not confident I've done everything right. Should be tested closely with users to ensure they understand this is thechecked
state.Left ear only
andBoth ears
headings on both pages. It was confusing why those appeared in some views but not others.Consider
Definition of Done