department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Add CI Check to flag manually modified cassettes #74993

Open ryan-mcneil opened 9 months ago

ryan-mcneil commented 9 months ago

Description

Manually modifying cassettes for requests external services can lead to issues in Production, as the request has not been validated against the service. An engineer may make changes to a cassette with assumptions about how it should work, but without re-recording, they cannot be 100% confident in the behavior. We should create a CI check that runs against modified cassettes, and throws an error if something in the diff seems abnormal

Tasks

Acceptance Criteria

rmtolmach commented 9 months ago

Another idea: