Closed shiragoodman closed 6 months ago
FYSA @jknipes - I think there's some other guidance in the VA GitHub Handbook that may also be communicated on Platform Website. I'm not sure we want to write our own guidance on VA Github policies for Platform Website if/when there is already guidance in the handbook. Let me know if you'd like to discuss further.
@shiragoodman thank you for the heads up, let's discuss how this should be presented.
Quick questions for @shiragoodman: Looking at the repos in the vets.gov-write team:
Read
permissions for the team. Read
has some capabilities associated with it, but not the ability to make any code edits. Since these repos presumably have higher access requirements, should the message in their README file be different than the other repos?Public archive
or Internal archive
) and can't be edited even if you have Write
permissions from vets.gov-write. Safe to skip those ones?I guess one more question @shiragoodman: Public repos are visible to everyone and Internal repos are visible to anyone in the VA GitHub Org. But Private repos won't be visible to anyone unless they're already members of vets.gov-write --- which means no one who would need to read the README instructions would be able to see them. There are 2 Private repos. Should these be handled differently?
@briandeconinck all good questions -thank you for being so diligent!
read
and write
repos the same. This is just a precautionary update we're making. Your README text says nothing about read/write, so I think it's safe to have the same messaging for the read
repos.Discussed at 2/26 Governance stand-up. PRs now opened for all repos, except:
read
permissions (because I can't do anything more than that!)@rferguson13 Some of these (like va.gov-team) you might be able to review and merge. Others have specific code owners who have to merge the PR.
End-of-sprint status! Six of 16 repos are waiting on codeowner review. Can't move these forward until an authorized reviewer gives the thumbs up.
The rest of the PRs have either been reviewed by a codeowner (thank you to Ian!) or don't have any specific reviewer requirements. I'll work with Rebecca to merge those over the next day or two. Carrying over into the next sprint.
Down to one! Request posted to the #platform-cop-devops channel for someone to approve department-of-veterans-affairs/devops/pull/14022, waiting on that.
Everything is merged, closing as complete!
User Story
As a Governance team member supporting Platform Orientation, I want to ensure that all teams and individuals requesting access to Platform repos are funneled through the same process (ie Platform Orientation) so that there is less confusion for VFS teams.
Assignee: @briandeconinck Peer Reviewer: @rferguson13
Description
Governance team was recently made aware of the VA GitHub Handbook . This is the guidance that the VA GitHub admins use for everything related to the VA GitHub Organization. There is guidance in the handbook that communicates how VA teams can gain access to the various repositories within VA GitHub. This guidance differs from the guidance that the VA.gov Platform crew provides to the VFS teams. The VA.gov Platform crew guidance communicates that repo access is managed through the vets.gov-write gh team and the only path for being added to the vets.gov-write gh team is through Platform Orientation. The GitHub handbook guidance communicates that individuals should review the README for the repo they'd like to gain access to for guidance on how to gain access. Currently, we do not believe that any of the repos associated with the vets.gov-write team have this messaging within their README files.
repos impacted
Impacted Artifacts
README text
Some quick notes on the thought process for the README text:
After some back-and-forth with Rebecca, I've landed on:
This should send everyone to the right place, and makes explicit that VFS team members need to complete the orientation ticket (which could get lost if we just point them to the Platform website page).
Tasks
[ ] /betamocks [read][ ] /breakers [read][ ] /covid19-chatbot [archive][ ] /platform-console-api [archive][ ] /va.gov-cms-devops [archive] [read][ ] /va.gov-support-slackbot [archive][ ] /va.gov-vfs-teams [archive] [read][ ] /vets-contrib [archive][ ] /vets.gov [archive][ ] /vsp-infra-demo [archive] [read]Peer Review
To be completed by peer reviewer
Acceptance Criteria
Team Notification
How to prepare this issue
Refinement
Planning
If this ticket is picked up from the Backlog mid-sprint, connect with Shira to ensure the below items are completed correctly