department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

EVSS PCIU Migration: Step 5: Remove PCIU requests model methods #76168

Open RachalCassity opened 8 months ago

RachalCassity commented 8 months ago

Test Plan: Step 5 Remove PCIU

Methods in the User and FormProfile models call the PCIU service. These calls should be removed. Ex:

app/user.rb
  def pciu_email
    pciu&.get_email_address&.email
  end

  def pciu_primary_phone
    pciu&.get_primary_phone&.to_s
  end

  def pciu_alternate_phone
    pciu&.get_alternate_phone&.to_s
  end

Tasks

Remove PCIU calls in the following files:

LindseySaari commented 5 months ago

@jennb33 After the meeting with Authenticated Experience, it will be a while before we take on this ticket. The migration work will come before this one, so we may want to create a discovery ticket to capture the work we completed this sprint. cc @RachalCassity

jennb33 commented 2 months ago

7/8 - when these are removed, put them behind a flipper so that we don't lose everything associated upon removal.

RachalCassity commented 1 week ago

PCIU replacement will continue after V3/AddressValidation has been deployed to staging.

jwoodman5 commented 2 days ago

Testing locally now plus a PR is up for review.