Open patrickvinograd opened 9 months ago
This issue is stale. If it is no longer valid, please close issue. Otherwise please update
Facilities team does believe this code is dead and could be removed. However: due to the important nature of the locator, this requires major testing pre-prod to ensure we don't disrupt the locator, just in case. My 2 cents: The Sitewide Facilities team should be involved in planning / code review, and required to perform QA regression pass before any related code can merge.
This PR did get merged. I am not clear on how many of the remaining ACs that are unchecked may / may not have been included in that PR, so not sure if this is done / can close, or if the PR that merged was only a subset of everything this ticket wanted to do.
Issue Description
I have verified with the sitewide facilities team that a bunch of legacy code and infrastructure related to facility locator can be safely removed.
app/models/BaseFacility
.*Facility
or*FacilityQuery
model classes other than specs and the aforementioned jobs.app/sidekiq/facilities
) are still running but appear to be uselessly updating the database that no active service is reading from.Once confirmed we can clean up all this code, plus remove at least one forward proxy configuration, and associated monitoring and pagerduty service.
Tasks
Facilities::*
references fromlib/periodic_jobs.rb
arcgis
inmodules/mobile/spec/models/service_graph_spec.rb
arcgis
andvha-access
forward proxy configurationsAcceptance Criteria
[ ] Obsolete references to an unused service will be removed, eliminating some ongoing maintenance burden and cognitive load.
How to configure this issue
product support
,analytics-insights
,operations
,service-design
,Console-Services
,tools-fe
)backend
,frontend
,devops
,design
,research
,product
,ia
,qa
,analytics
,contact center
,research
,accessibility
,content
)bug
,request
,discovery
,documentation
, etc.)