department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Decommission obsolete ArcGIS/facilities code #76315

Open patrickvinograd opened 9 months ago

patrickvinograd commented 9 months ago

Issue Description

I have verified with the sitewide facilities team that a bunch of legacy code and infrastructure related to facility locator can be safely removed.

Once confirmed we can clean up all this code, plus remove at least one forward proxy configuration, and associated monitoring and pagerduty service.


Tasks

Acceptance Criteria

va-vsp-bot commented 6 months ago

This issue is stale. If it is no longer valid, please close issue. Otherwise please update

jilladams commented 2 months ago

Facilities team does believe this code is dead and could be removed. However: due to the important nature of the locator, this requires major testing pre-prod to ensure we don't disrupt the locator, just in case. My 2 cents: The Sitewide Facilities team should be involved in planning / code review, and required to perform QA regression pass before any related code can merge.

jilladams commented 1 month ago

This PR did get merged. I am not clear on how many of the remaining ACs that are unchecked may / may not have been included in that PR, so not sure if this is done / can close, or if the PR that merged was only a subset of everything this ticket wanted to do.