search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Spike | Failing Award Service API #76465

Open steele-lm opened 9 months ago

steele-lm commented 9 months ago

Issue Description

Original epic to implement the values associated with the net income question: https://github.com/department-of-veterans-affairs/va.gov-team/issues/7759

Currently, all dependency pension claims submitted to RBPS SHOULD off-ramp for manual processing because a person must review income and net worth information. (We need to validate this is happening.) Until this information is submitted to RBPS from VA.gov, these pension claims cannot be processed through RBPS and will continue to be off-ramped for manual processing. UPDATE: Daniel Gifford from the VBA pension line of business confirmed that pension leadership wants the questions that do not match the form (e.g., net worth question) to be removed from the 686/674 VA.gov form flow.

Research done in #73696 determined that a flipper in production is preventing this information from being passed to RBPS. The flipper controls code that calls an outside service, and that service is currently failing for an unknown reason. RBPS may also have had issues accepting the new values.

Suspicion is that this service may return the current net worth limit and indicate if the Veteran is eligible of or in receipt of pension, which would mean they need to answer the net worth question at the end of the 686/674 form flow (and the "did this student have income" question?). If the Veteran is receiving a pension benefit, VA.gov should set the claim for manual processing (and not send it to RBPS) and label the claim.

The call is an Oracle call as follows:

ws_award_data_prc. vetIsEligCplPension, will always return one row.

PROCEDURE vetIsEligCplPension (pi_vet_id IN NUMBER ,po_isEligibleForPension OUT VARCHAR2 ,po_vet_found OUT VARCHAR2 ,po_isInReceiptPension OUT VARCHAR2 ,po_net_worth_limit OUT NUMBER ) IS

Tasks

Acceptance Criteria

AmyPlange commented 2 months ago

CC: @steele-lm from zoom chat See comments in this ticket: https://github.com/department-of-veterans-affairs/va.gov-team/issues/73696 RBPS issue: https://github.com/department-of-veterans-affairs/va.gov-team/issues/18910

micahaspyr commented 2 months ago

There is a logic failure that was mentioned by Dewayne in that #73696 ticket. There is no check done to see if the net worth is greater/equal/less than the $130,773 limit.

All that is need is to add in that check for that value

micahaspyr commented 2 months ago

Ignore the above mentioned logic issue. The check that is being done returns a boolean true/false. I'm think there may have been some confusion as the form key is 'household_income' but it returns true or false, not a number of any type.

micahaspyr commented 2 months ago

@sanjabaj2 I've twice now reached out to our contacts on this issue. Hopefully I see a response, but I may need help in escalating this further.

sanjabaj2 commented 2 months ago

I am not sure it is clear what is your question? Today's email is asking them to check your test from today. Also, did you check that service award Swagger link?

micahaspyr commented 2 months ago

@sanjabaj2 no need to worry as I think we have some more eyes on this.

Update:

Linda Ciston gave me the contact to give info on connecting to the PRODTEST db instead of the LINKTEST db. However, I'm not sure what exactly to do with the info I was given. Maybe @evansmith can give some further insight tomorrow