search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Correct `net_worth_over_limit_ind` logic #76468

Open steele-lm opened 8 months ago

steele-lm commented 8 months ago

Issue Description

_Research done in #73696 discovered that a possible business logic error where the net_worth_over_limit_ind is always set to Yes._

Ticket to fix failing service associated with passing the net_worth_over_limit_ind is #76465.

Tasks

Acceptance Criteria

micahaspyr commented 1 month ago

I noticed that some boolean checks in various parts of the pdf_fill code return a 'Y' or 'N' whereas the fixed method looks to return 'Yes' or 'No'. The Yes/No may only be applicable to RBPS.

That being said, the offending code has been rectified but will need to be tested