[FE] Placeholder for anything that was missed because of changing content/design

[loripusey]

Tasks

• [x] Review Figma wireframes to identify anything we missed
• [x] Fixed missing things
• [x] small change to the text that's bolded (in body text under the h1) for both multi and single facilities review pages:
  • Wireframe for multi
  • Wireframe for single
• [x] Update text on validate page. We have File a travel reimbursement claim if you’re eligible for health care travel reimbursement. First, we need your last name and date of birth to make sure it’s you. Should be First, we need your last name and date of birth to make sure it’s you.
  • wireframe
• [x] Remove secondary action link from intro page and remove open in blank window from travel reimbursement eligibility link
  • wireframe
• [x] Add What you're claiming to review page
  • wireframe
• [x] Fix issue where 45MR is getting appended to yes/no events on non day-of check-in pages including travel
• [x] Clicking no on travel question pages does not route to the proper page. Need to pass a "No" function
• [x] Add facilityType param to get session and other API requests for travel-claim only facilityType=oh
• ~Address a11y ticket https://github.com/department-of-veterans-affairs/va.gov-team/issues/77000~

[loripusey]

@brianseek @benbrasso-agile6 I added this ticket because I think that some of the content has shifted during the development; thought we needed a ticket to check what we have against the final wireframes to ensure we captured everything

[lee-delarm6]

Closing based on conversation with @brianseek and @benbrasso-agile6 , we've added a overarching summary title to the checkbox group which is read. This should cover the necessary description of the checkboxes

[brianseek]

Lets keep this open as an audit on the designs. There are still in-flight changes, like the changes to the review page and the intro page also has unaddressed updates

[brianseek]

@benbrasso-agile6 / @cgednalske / @zach-park This isn't merged yet. But if you want to get a jump start on validation, here are the screenshotstravel-app-screens.zip

if you want to see anything local the branch is check-in/77013/remove-eyebrow

[loripusey]

I compared the screenshots to the content in Figma, looks good to me. Are we ready to fully test in a local env yet @brianseek ?

[brianseek]

@loripusey sure! This isn't merged yet, but you can use this branch check-in/77013/remove-eyebrow and there are details in the readme here: https://github.com/department-of-veterans-affairs/vets-website/tree/main/src/applications/check-in#mock-uuids

and more here: https://github.com/department-of-veterans-affairs/vets-website/tree/main/src/applications/check-in/travel-claim#how-to-run-locally

[loripusey]

I will give it a whirl, though if I fail, I may wait till Monday so it doesn't wreck my weekend :)

[loripusey]

Otherwise I may spend all day fretting and then be grumpy over the weekend

[brianseek]

@loripusey feel free to send a zoom for co-working if it gives you any trouble

[benbrasso-agile6]

[brianseek]

This is merged and ready to be validated

[loripusey]

Validated against the TestRail test cases; @benbrasso-agile6 do you want to validate against the new Figma content with recent changes? I validated the zip file of screenshots against Figma last week but not sure if that accounted for recent changes

[benbrasso-agile6]

Yeah, I'll take a look at the zip

[benbrasso-agile6]

Nice work. That was a lot!

Noticed a couple small things:

• On the address page, are we able to do a line break after street address (i.e., similar format in Demo questions)?
• On the review page, on the validation error, can we bold the "By submitting..." sentence? I believe we're supposed to.
• On the review page, are we able to do a line break after street address (i.e., similar format in Demo questions)?

[brianseek]

For the address formatting, there is a thread about that in slack that Lee started somewhere. In short, no not really. We only have a single text field for the address, so we have no idea where the street begins and ends.

On the error, the component takes care of all that and in this scenario it doesn't bold: https://design.va.gov/storybook/?path=/docs/uswds-va-checkbox-group--default#forms-pattern-single-error

I'm not really sure the difference or what that means but the component is doing what it is doing on purpose.

[brianseek]

looks like there was never a resolution on it: https://dsva.slack.com/archives/C02G6AB3ZRS/p1709585291986289

[brianseek]

it was kind of an all the breaks or none of them option

[benbrasso-agile6]

Consider these resolved. I'll update couple these in Figma. Thanks @cgednalske FYI, since you were a part of the address break convo. No action needed here.

[benbrasso-agile6]

Took care of these edits in Figma so we all stay synced up