department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Implement non-registered user alert on my-health tools #77237

Closed wesrowe closed 4 months ago

wesrowe commented 7 months ago

Description

User story

As an authenticated user who is not registered to a VA facility, I want health apps within the /my-health/ portal on VAgov to alert me to the fact that I don't have access to health tools, so that I have enough information to take action if appropriate.

Notes

Possible tasks:

Acceptance criteria

Associated PRs:

  1. Add mhv route guard to after visit summary - MERGED
  2. Add mhv route guard to medications - 2 Approvals needed, 1 from our team
  3. Add medical records mhv route guard - 2 Approvals needed, 1 from our team
  4. Add mhv route guard to Secure Messaging - CLOSED due to Oracle migration which will bring in users that don't rely on the vets-api
  5. Add mhv route guard to supply re-ordering - 2 Approvals needed, 0 from our team
  6. Add route guard component and unit test and copy for NoHealthAlert - MERGED
wesrowe commented 7 months ago

refine after design is complete – may be complex (eg H1 challenge)

wesrowe commented 7 months ago

I removed the blocker on this one, as Sara's work on the non-registered alert is complete. (I.e., no controversy or questions around that section of the mural.)

wesrowe commented 7 months ago

Sara to message tool owners for permission for this work.

wesrowe commented 7 months ago

update: as linked in first AC, Sara got sign-off in slack from MHV stakeholders about using the route-guard idea for un-registered users – i.e. taking any un-registered user from the tool page they tried to access to the MHV landing page with the un-registered alert. Biggest point of discussion was Appointments edge case around claim exams (aka compensation and pension exam).

sterkenburgsara commented 7 months ago

Per Lauren Alexanderson & Laura Willwerth in Slack, there is a slight update to the alert we need to make in production: update the text in the first line of the alert to say "at least one."

Screenshot 2024-03-19 at 4 21 07 PM
jzucadi commented 4 months ago

Secure messaging currently has a validation process for showing an alert to users based on backend services aka the vets-api. The route guard PR was closed due to an upcoming Oracle migration which will bring in a new set of users that do not have the mhvAccountState property in the vets-api

LynneJohnson224 commented 4 months ago

@wesrowe @jzucadi my notes from planning yesterday were that we will close this ticket and address the issues in 2 new tickets. Can we close this?