[CST] Decision letter available alert gets specific language for open claims and goes away when claim is closed.

skylerschain commented 8 months ago

Value Statement

As a Veteran I want to know that I have a decision letter available for part of my claim even if the claim is still open So that I have an accurate understanding of my claim status (that certain contentions are still open and some have been decided)

Background Context

Sometimes a decision letter is available for certain contentions in a claim, even if the overall claim is still open (usually occurs if contentions were deferred).

We had a design for this in the old version of the UI. We need to design and implement this for the V2 detail pages.

Design

FIGMA

Proposed UI

Current UI

Engineering

From Peri: "There is currently not any logic on the Status Tab that shows a link to the claims letter page or mentions a decision letter when A claim is opened OR when a claim has a decision letter sent.

The specific logic that we use to determine if a claim is opened is a helper function called isClaimOpen() that is passed in the following claim fields claim.attributes.status and claim.attributes.closedDate. The claim is considered opened as long as the status is not COMPLETE and the closedDate is null. The specific logic that we use to determine if a claim has a decisionLetterSent is by looking at the claim field claim.attributes.decisionLetterSent."

Out of scope

Add here

Open questions

If possible we should apply this to all claim types that have decision letters in Claim Letters page. Is that feasible?
What do we do if there are multiple decision letters for the same claim? So if there are two different letters to show but claim is still open?

Tasks

[ ] If a claim is open (as defined above) and a decision letter HAS been sent (as defined above), show the proposed design on the Status page for the claim
[ ] Show the new alert until the claim is closed, at which point the standard close claim UI will replace it
[ ] Update vets-api-mockdata so that we have a claim that is opened and has decisionLetterSent: true

Definition of Done

[ ] Meets acceptance criteria
[ ] Passed E2E testing (90% coverage)
[ ] Passed unit testing (90% coverage)
[ ] Passed integration testing (if applicable)
[ ] Code reviewed (internal)
[ ] Submitted to staging
[ ] Team approved production verification process
[ ] Design performs design QA and verifies the implementation matches the design spec
[ ] Engineering identifies staging users required to test and shares account and credentials with product
[ ] Product performs functional QA and verifies acceptance criteria was met

Acceptance Criteria

[ ] Claims that are open and have a decision letter sent show the proposed design
[ ] The "You have a decision letter for part of this claim" alert is shown until the claim is completely closed, at which point the standard closed claim state replaces it
[ ] vets-api-mockdata has an opened claim with a decisionLetterSent: true

jacobworrell commented 3 months ago

veterans who have decision letters for open claims can see them in the claim status tool claim letter section.

skylerschain commented 3 months ago

@jacobworrell True but they won't know to go there to look for it without some sort of notification. I think it's worth keeping a ticket open to add that.

jacobworrell commented 2 months ago

@skylerschain a partially decided claim will show the same message as a closed claim directing them to the claim letters section of CST. Jerek and I investigated this and the message will show up for a claim that is still open. If you'd like a different message to show for partially decided claims, that might make sense, but I think the value prop for this ticket would need to change.

skylerschain commented 2 months ago

The value prop is the same:

As a Veteran I want to know that I have a decision letter available for part of my claim even if the claim is still open so that I have an accurate understanding of my claim status

Below is the message we show for closed claims, and this language definitely makes it sound like the claim is closed, which in this case it's not. So we need a different version for when some contentions are still being decided. The spec is here.

jacobworrell commented 1 month ago

@skylerschain please update mock with correct position of alert.

skylerschain commented 1 month ago

Mock finalized and FIGMA link in #Design section has been updated.

skylerschain commented 1 month ago

Removed this from Tasks:

[ ] If a second decision letter becomes available, stack the second (newer) alert on top of the first so that Veterans can see that they have multiple decision letters available. If a third becomes available, place the third on top of the stack, and so on.

Reason: As described in the spec, there is no signal differentiation between when the Veteran has one decision letter and claim is open and when the Veteran has multiple decision letters and the claim is open. So UI treatment will be the same in both cases.

jacobworrell commented 4 weeks ago

@jerekshoe please review so we can merge

jerekshoe commented 4 weeks ago

@skylerschain The last sentence in the alert mentions that the copy of the decision letter in the mail should arrive within 10 days after the claim is closed, but in this case the claim isn't closed yet (and it may not be closed for a while). Should we have changed the copy there?

skylerschain commented 4 weeks ago

@jerekshoe Good catch.

@samcoforma Can we update the last line of the alert:

Before:

We’ll also send you a copy of your decision letter by mail. It should arrive within 10 days after the date we closed your claim, but it may take longer.

After:

We’ll also send you a copy of your decision letter by mail. It should arrive within 10 days, but it may take longer.

department-of-veterans-affairs / va.gov-team