Open jerekshoe opened 8 months ago
Waiting on LH to update their service to return correct disability ratings
@jerekshoe will check in with them today to see if there's an update
They said they should have a fix on Thursday
@jerekshoe is meeting with LH today to discuss what needs to happen with this. Likely won't be a fix until next week
LH said they will have a fix out today, Jerek to verify
Jerek will verify tomorrow
LH pushed out their latest updated today. Turned the feature toggle up to 10% to see if it produces any results
Received some logs saying there are discrepancies. Jerek is going to investigate and possibly make new tickets
6/27 - They pushed out the hotfix this morning. Jerek is going to validate and if all looks good he will start this ticket
Jerek validated the hotfix and this is ready to be worked again. Moving to product backlog to be reprioritized.
Summary
Once we have reached a point where the length discrepancy logging is not producing any more results, we should modify the length check to manually check the IDs of all of the rated disabilities returned by EVSS and Lighthouse (after we have filtered out inactive ratings and those with unwanted decision values). This should ensure that we are returning the exact same list of ratings as EVSS did, not just the same number of ratings
Context
app/controllers/v0/rated_disabilities_discrepancies_controller.rb
if lh_response_length != evss_response_length log_length_discrepancy((lh_response_length - evss_response_length).abs) end