department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 200 forks source link

Update to new PDF using checkboxes (instead of radio buttons) #77490

Closed vbellissimo closed 6 months ago

vbellissimo commented 6 months ago

Issue Description

All radio buttons have been replaced with checkboxes:

image.png

To do


Acceptance Criteria

aplatt-coforma commented 6 months ago

Hey team! Please add your planning poker estimate with Zenhub @danlim715 @mjknight50 @scottsdevelopment @TaiWilkin @wayne-weibel

danlim715 commented 6 months ago

Unfortunately, the circle fields and square fields are not toggle-able via a metadata setting. Circle fields are radio buttons and square fields are checkboxes, and those 2 field types fundamentally behave differently. We would have to rename every checkbox field in the PDF and rewrite large portions of the backend code to accommodate checkboxes instead of radio button list groups, which would turn this ticket from a 1 pointer to something like an 8 or 13 pointer.

buddhima-coforma commented 6 months ago

This change is needed so let's proceed with it. Here's a reference conversation https://dsva.slack.com/archives/C05MS96P6P2/p1710265938433459

danlim715 commented 6 months ago

PR: https://github.com/department-of-veterans-affairs/vets-api/pull/15998

aplatt-coforma commented 6 months ago

Looks good content.pdf