department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 196 forks source link

Address pattern #78828

Open megzehn opened 4 months ago

megzehn commented 4 months ago
humancompanion-usds commented 3 months ago
megzehn commented 3 months ago

Questions for address pattern page:

What are the main reasons we separate a Single address layout from the Multiple addresses layout? The layouts are nearly identical, aside from the header and explainer body text on the Multiple address layout. But I think in most cases, we probably still want the header and body explainer text even if we're just asking for one address. This is the case in the mock form pattern.

megzehn commented 3 months ago

Under content considerations

Could we reorder and relabel the fields like this?

  • Label
  • Hint text:
  • Error type 1:
  • Error message 1:

Could we group all errors types and error messages together for a single field?

  • Postal code
  • Hint text: None
  • Error type 1: No entry
    • Error message 1: Enter a postal code
  • Error type 2: Incorrect entry
    • Error message 2: Enter a valid 5- or 9-digit zip code (with or without dashes)

Could we add a "notes" line on fields that have known variations?

  • Street address
  • Label variations: Apartment or unit number
megzehn commented 2 months ago

[Editing this comment to link to a PR instead]

@humancompanion-usds, I created this PR with label updates for addresses. Could you review and merge when you can?