[Claims Details V2] Remove disabled button on Ask for your claim decision page

davidakennedy commented 5 months ago

Value Statement

As a Veteran using a screen reader or other assistive technology I want tobe able to ask the VA for a claim decision and not stumble over a disabled button So that I can accomplish my task more quickly.

Background Context

Bug

Issue description

URL: /track-claims/your-claims/009_ClaimWithTrackedItems/ask-va-to-decide

The "Ask for your claim decision" page has a disabled submit button that only becomes active after you've activated the checkbox. Disabled buttons can cause confusion for screen reader users and others who use assistive technology. This isn't a WCAG violation, but strongly discouraged based on design system guidance.

It's worth noting that a similar pattern exist on the "Claim files" page (/track-claims/your-claims/600351984/files), and it doesn't have a disabled button. So a change here would align the two pages.

Screenshot of Ask for your claim decision page with an arrow pointing to disabled submit button.

This is a a11y-defect-4 issue.

Remediation guidance

Change the disabled button to a regular one, and include an error message if the checkbox isn't checked.

Does this impact visual design?

Yes, the button will change appearance and an error message will need to be included.

Relevant standards

N/A

Definition of Done

[ ] Meets acceptance criteria
[ ] Passed E2E testing (90% coverage)
[ ] Passed unit testing (90% coverage)
[ ] Passed integration testing (if applicable)
[ ] Code reviewed (internal)
[ ] Submitted to staging
[ ] Team approved production verification process
[ ] Design performs design QA and verifies the implementation matches the design spec
[ ] Accessibility specialist performs accessibility review (in code or design)
[ ] Engineering identifies staging users required to test and shares account and credentials with design and product
[ ] Product performs functional QA and verifies acceptance criteria was met

Acceptance Criteria

[ ] Disabled button is changed to a regular one
[ ] Error exist when the checkbox isn't checked, and follows accessibility guidance for error messages.

davidakennedy commented 5 months ago

Note here that @jstrothman mentioned during Sprint Review that when the team picks up this work, it should look broadly the design of the interactions here. It's more tricky than it looks.

jacobworrell commented 3 months ago

closing this because our 5103 initiative encompasses this request.

jacobworrell commented 2 months ago

re-opening adding to blocked

pmclaren19 commented 1 month ago

This ticket will be blocked until we release the https://github.com/department-of-veterans-affairs/va.gov-team/issues/81212 for Improving 5103 tracked items.

department-of-veterans-affairs / va.gov-team