department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Implement Allowlisting Validation for RepresentativeUser #80613

Closed gabezurita closed 3 months ago

gabezurita commented 5 months ago

Description

ARF must introduce a validation mechanism for RepresentativeUser entities to ensure that only authorized users can access the portal. The proposed solution is to implement a pilot version of an allowlisting strategy. This strategy involves adding an enabled: bool attribute (or similar) to the RepresentativeUser model. The ARF engineers will manage this attribute via a static JSON file within the vets-API repository, providing a foundational allow listing mechanism. Additionally, exploring the development of a UI for admin-type users to manage this whitelist is recommended.

Key Discussion Points and Decisions

Acceptance Criteria

cohnjesse commented 4 months ago

We have decided to go with Flipper feature toggles, here is a document discussing why - https://docs.google.com/document/d/11fPKXlnrnPzU9TkNxqYFJZylE_sd7MBC-M_wuwUlqUQ/edit#heading=h.9fysbe2p4bfs