department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Collaboration Cycle for the Public Websites Team for the Discharge Upgrade Wizard #80777

Open FranECross opened 7 months ago

FranECross commented 7 months ago

VFS product information

VFS team name

Public Websites

Product name

Discharge Upgrade Wizard

Feature name

The entire Discharge Upgrade Wizard, not a particular feature within it.

GitHub label for team

Public Websites

GitHub label for product

Discharge wizard

GitHub label for feature

N/A

Public DSVA Slack channel for VFS team

sitewide-public-websites

Kickoff questions

Toggle kickoff questions ### When did/will you start working on this product/feature? Jan 25, 2024 ### Will your work result in visible changes to the user experience? Yes ### Are you doing research with VA.gov users? No ### Will your work involve changes to... Both ### Does your product/feature have Google Analytics tracking and a KPI dashboard in Domo? Yes ### Do you need to capture any additional analytics or metrics? Yes, user flows ### Product outline - https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/veteran-military-records/discharge-upgrade-wizard/initiatives/2024-discharge-upgrade-wizard-subtask/initiative-brief.md ### Verify all relevant materials provided to Governance Team - [X] I have provided all relevant and up-to-date links, screenshots, images, designs, etc. of the as-is version of the product - [Legacy User Flow in Mural with Legacy screenshots](https://app.mural.co/t/departmentofveteransaffairs9999/m/departmentofveteransaffairs9999/1696352911500/80253b1c7200212cbcbcfb940d2cf4a29fed8417?sender=u71e5a9ded413bfa79dd23932) ### Add the GitHub labels for your team, product, and feature to this ticket. - [X] I acknowledge that I must add the GitHub labels for my team, product, and feature to this ticket. ### Notify the Collaboration Cycle team of this ticket in your team's public Slack channel. - [X] I acknowledge that I must notify the Governance team by completing the Collab Cycle Kickoff workflow in my team's Slack channel after submitting this issue. This can be completed by typing "/collab cycle" and selecting the kickoff workflow. Kickoff Slack Thread with VFS team: [Kickoff thread](https://dsva.slack.com/archives/C52CL1PKQ/p1713217994167679)

PO Sync πŸ‘‰πŸ½ This step was added quite some time after the project began.

Toggle PO Sync instructions #### Before the meeting ##### OCTO Product Owner - [ ] Review [PO Sync Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/po-sync) to understand what this sync involves. - [ ] Schedule your PO Sync (with at least 2 business days lead time from now): - Open the [Calendly PO Sync calendar](https://calendly.com/collaboration-cycle/po-sync) - Select a date and time and click "Confirm" - Add your name and email - Click "Schedule Event" - [ ] Link all artifacts in the `PO Sync artifacts for review` section below at least two business days before the scheduled PO Sync. Please don't add artifacts in the comments section. **PO Sync artifacts for review** [See guidance on PO Sync artifacts.](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/po-sync#POSync-Whatartifactswillbeneeded?) Please provide links to artifacts **at least two business days** before the scheduled meeting. Required: - [ ] Product outline Optional: - [ ] Any other artifacts you have so far ##### Governance Team actions - [ ] Meeting date/time: #### After the meeting ##### OCTO Design Leads - [ ] If the initiative receives OCTO alignment to proceed, add the PO-Sync-approved label to this ticket. - [ ] If the initiative does not receive OCTO alignment to proceed, comment and close this ticket.

Design Intent πŸ‘‰πŸ½ Skipped

Toggle Design Intent instructions #### Before the meeting ##### VFS team actions - [ ] Review [Design Intent Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/design-intent) to understand what this touchpoint involves. - [ ] Schedule your Design Intent (with at least 2 business days lead time from now): - Open the [Calendly design intent calendar](https://calendly.com/collaboration-cycle/design-intent-or-midpoint-review) - Select a date and time and click "Confirm" - Add your name and email - Click "Add Guests" and enter the email addresses for VFS team attendees - Click "Schedule Event" - [ ] Link all artifacts in the `Design Intent artifacts for review` section below at least two business days before the scheduled Design Intent. Please don't add artifacts in the comments section. **Design Intent artifacts for review** [See guidance on Design Intent artifacts.](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/design-intent#Designintent-Artifacts) Governance Team feedback is based on the artifacts provided here as well as information provided during the meeting. Please provide links to artifacts **at least two business days** before the scheduled meeting. Required: - [ ] User flow Not required, but nice to have: - [ ] Wireframes (if provided, must include mobile wireframes) Optional: - [ ] Research plan - [ ] Any other artifacts you have so far ##### Governance Team actions - [ ] Design Intent Slack thread with VFS team - [ ] Meeting date/time: #### After the meeting ##### Governance Team actions - [ ] Update this ticket with the Zoom recording - Recording link - Passcode: - Accessibility - [ ] Feedback ticket attached - [ ] No feedback - Design - [ ] Feedback ticket attached - [ ] No feedback - IA - [ ] Feedback ticket attached - [ ] No feedback ##### VFS team actions - [x] Review feedback tickets. Comment on the ticket if there are any questions or concerns.

Architecture Intent πŸ‘‰πŸ½ Passed

Toggle Architecture Intent instructions #### Before the meeting ##### VFS team actions - [x] Review [Architecture Intent Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/architecture-intent) to understand what this touchpoint involves. - [x] Schedule your Architecture Intent (with at least 2 business days lead time from now): - Open the [Calendly Architecture intent calendar](https://calendly.com/collaboration-cycle/architecture-intent) - Select a date and time and click "Confirm" - Add your name and email - Click "Add Guests" and enter the email addresses for VFS team attendees - Click "Schedule Event" - [x] Link all artifacts in the `Architecture Intent artifacts for review` section below at least two business days before the scheduled Architecture Intent. Please don't add artifacts in the comments section. **Architecture Intent artifacts for review** [See guidance on Architecture Intent artifacts.](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/architecture-intent#ArchitectureIntent-Whatartifactswillbeneeded?) Feedback is based on the artifacts provided here as well as information provided during the meeting. Please provide links to artifacts **at least two business days** before the scheduled meeting. Required: - [x] Fully completed [Architecture Intent Meeting Template](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/platform/engineering/collaboration-cycle/architecture-intent/checklist/Public%20Websites%20Team%20-%20Discharge%20Upgrade%20Wizard%20-%202024-10-22.md) - [N/A] [User data flow diagram](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/platform/practices/zero-silent-failures/how-to-create-a-user-data-flow-diagram.md), if your application accepts data from a user. ##### Platform Team actions - [x] Meeting date/time: Monday October 28, 4:30pm ET #### After the meeting ##### Platform Team actions - [ ] Update this ticket with the Zoom recording - Recording link - Passcode: - Engineering feedback - [ ] Feedback ticket attached to milestone - [x] Feedback added below Strong recommendations: - Use a timer to clear the state of the wizard after a reasonable period of inactivity (suggest 5 minutes) Also consider: - Add Cypress tests to check external site links - [ ] No feedback - Mobile Engineering feedback - [ ] Feedback ticket attached to milestone - [ ] No feedback - Security feedback - [ ] Feedback ticket attached to milestone - [ ] No feedback ##### VFS team actions - [ ] Review feedback tickets. Comment on the ticket if there are any questions or concerns.

Research Review πŸ‘‰πŸΌ N/A

VFS actions

Midpoint Review πŸ‘‰πŸ½ Skipped

Toggle Midpoint Review #### Before meeting ##### VFS actions Navigate to reference link: [Midpoint Review Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/midpoint-review) - [ ] Schedule your Midpoint Review when ready: - Open the [Calendly midpoint review calendar](https://calendly.com/collaboration-cycle/design-intent-or-midpoint-review) - Select a date and time and click β€œConfirm” - Add your name and email - Click "Add Guests" and enter the VFS meeting attendees email addresses - Invite all relevant VFS team members, including accessibility support, product owners, and other VA stakeholders - Click "Schedule Event" - [ ] Check this box if you'd like this review to be asynchronous (Please refer to the [Midpoint Review guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Midpoint-review.1781039167.html) for the difference between a synchronous meeting and an asynchronous review) - [ ] Link all artifacts **ONLY** in the Midpoint Review artifacts section below at least two days before the scheduled Midpoint Review. **Do NOT add artifacts to Comments section** **Midpoint Review artifacts** See Platform guidance on [Midpoint Review artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/midpoint-review#Midpointreview-Artifacts). Platform feedback is based solely on the artifacts provided, as reviewed during the two days before the Midpoint Review meeting. Any work not included in the artifacts below or any ongoing work taking place during the review period may not be reflected in that feedback. **Required artifacts** - [ ] Design prototype or high-fidelity mockup (must include mobile prototype/mockup) - Specify which pages are included in the review - [ ] Up to date user flow - [Guidance on user flows](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/information-architecture/standards/user-flow-guidance.md) - [ ] If working with [Sitewide CAIA](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/sitewide-content-and-ia-intake-request), link to CAIA intake ticket. **Not required, but nice to have artifacts** - [ ] Accessibility annotations included as part of your design - [ ] Research plan - Links to specific CAIA artifacts: - [ ] IA spec - [ ] Content source of truth - Any other artifacts you have so far ##### Platform actions - [ ] Slack thread with VFS team - [ ] Meeting date/time: #### After meeting ##### Platform actions * Accessibility * [ ] Feedback added to milestone * [ ] No feedback * Content * [ ] Feedback added to milestone * [ ] No feedback * Design * [ ] Feedback added to milestone * [ ] No feedback * IA * [ ] Feedback added to milestone * [ ] No feedback * [ ] Update this ticket with the Zoom recording - Recording link - Passcode: ##### VFS actions - [x] Review feedback tickets and comment on the ticket if there are any questions or concerns

Analytics Request πŸ‘‰πŸ½ Submitted

Toggle Analytics Request #### VFS actions - [X] Complete the [analytics request process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Analytics-request.1782120453.html) - [X] Link to the Analytics Implementation and QA Request ticket below - [x] Analytics [Ticket](https://github.com/department-of-veterans-affairs/va.gov-team/issues/93966)

Contact Center Review πŸ‘‰πŸ½ Passed

Toggle Contact Center Review #### VFS actions - [X] Complete the [Contact Center review process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Contact-center-review.1782317061.html) - [X] Link to the Contact Center review request ticket below - [ ] https://github.com/department-of-veterans-affairs/va.gov-team/issues/93785

Staging Review πŸ‘‰πŸ½ Scheduled

Toggle Staging Review #### Before meeting ##### VFS actions - Navigate to reference link: [Staging Review Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/staging-review) - [x] Schedule your Staging Review when ready: - Open the [Calendly staging review calendar](https://calendly.com/collaboration-cycle/staging-review) - Select a date and time and click β€œConfirm” - Add your name and email - Click "Add Guests" and enter the VFS meeting attendees email addresses - Invite all relevant VFS team members, including accessibility support, product owners, and other VA stakeholders - Click "Schedule Event" (*Scheduled for 12:30pm - 1:00pm, Tuesday, December 3, 2024) - [N/A] If this product contains any [experimental design](https://design.va.gov/experimental-design/), add the `experimental-design` label and schedule a meeting with DSC to present the research findings. - **N/A (no experimental designs)** - [x] Link all artifacts **ONLY** in the Staging Review artifacts section below at least four days before the scheduled Staging Review. **Do NOT add artifacts to Comments section** - [x] I confirm the environment is available and test users have been provided. - Staging environment is available at: https://staging.va.gov/discharge-upgrade-instructions/introduction - No test users needed; unauthenticated experience/wizard. - [x] Please verify your product information in the [Product Directory](https://depo-platform-documentation.scrollhelp.site/getting-started/vfs-product-directory). **Staging Review artifacts** Links to [Staging Review artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Staging-review.1810137181.html#Stagingreview-Artifacts) must be added to this ticket 4 business days ahead of the scheduled meeting. Please do not make changes to the product or artifacts during the 4-day review period. #### Required artifacts - [X] **URL(s) to review the product** - The product should be available on an [approved staging environment](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/staging-environment-guidance-for-vfs-teams). - List pages, sections of pages, and/or user flows impacted by this work. List of possible URLs listed below. Note that there is logic that drives which questions are presented to a user, based their answers to previous questions: - User flows shown based on Logic in this [Mural ](https://app.mural.co/t/departmentofveteransaffairs9999/m/departmentofveteransaffairs9999/1696352911500/80253b1c7200212cbcbcfb940d2cf4a29fed8417?sender=u71e5a9ded413bfa79dd23932) - The following are a list of all the screens, but not all display to a user because their answers drive the branching logic (see the Mural noted above). Note that you **_can't_** get to the screens directly by copy/pasting the URL into the browser. - Introduction page (URL to start the wizard): https://staging.va.gov/discharge-upgrade-instructions/introduction (beginning screen) - https://staging.va.gov/discharge-upgrade-instructions/service-branch - https://staging.va.gov/discharge-upgrade-instructions/discharge-year - https://staging.va.gov/discharge-upgrade-instructions/discharge-month - https://staging.va.gov/discharge-upgrade-instructions/reason - https://staging.va.gov/discharge-upgrade-instructions/discharge-type - https://staging.va.gov/discharge-upgrade-instructions/intention - https://staging.va.gov/discharge-upgrade-instructions/court-martial - https://staging.va.gov/discharge-upgrade-instructions/prev-application - https://staging.va.gov/discharge-upgrade-instructions/prev-application-year - https://staging.va.gov/discharge-upgrade-instructions/prev-application-type - https://staging.va.gov/discharge-upgrade-instructions/failure-to-exhaust - https://staging.va.gov/discharge-upgrade-instructions/prior-service - https://staging.va.gov/discharge-upgrade-instructions/review - https://staging.va.gov/discharge-upgrade-instructions/results - [x] **Drupal or Staging URL for updated primary entry point**: the main way Veterans will access the tool through site navigation (not search) - **The Introduction URL noted above (all URLs noted above) is different than the one in production. When this is released to production, a redirect will also be implemented and released which will redirect users to the start page of the new wizard.** - [x] **~Test users and~ scenarios (when applicable)** - ~Store [test user information](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/Administrative/vagov-users/staging-test-accounts-accessible-example.md), passwords, and tasks in a `.md` file in the va.gov-team-sensitive repository.~ - Make sure all user scenarios can be tested, i.e.: in-progress form, submitted form, new form. - [X] **[Link](https://github.com/department-of-veterans-affairs/va.gov-team/issues/92611) to Sitewide CAIA intake ticket, if applicable.** - [x] **Completed accessibility testing [artifact](https://github.com/department-of-veterans-affairs/va.gov-team/issues/93569)**: [see instructions and link to accessibility testing template](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/prepare-for-an-accessibility-staging-review). - [X] **QA Artifacts**: artifacts that correspond to each of the [QA Standards](https://depo-platform-documentation.scrollhelp.site/developer-docs/quality-assurance-standards). [**QA Artifact Document for DUW**](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/veteran-military-records/discharge-upgrade-wizard/initiatives/2024-discharge-upgrade-wizard-subtask/testing-qa.md) - [X] Regression test plan - [X] Test plan - [X] Coverage for References - [ ] Summary (Defects) reports - [X] E2E tests - [X] Code coverage - [N/A] Endpoint monitoring playbook #### Issues to be Addressed & Released Pre-Launch - [Discharge Upgrade Wizard] Content updates from Joshua Gibbs for Form 149 information [#19557](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19557) - [Discharge Upgrade Wizard] Results screen information is missing for many Air Force and some other military branch scenarios [#19785](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19785) (In QA) - [Discharge Upgrade Wizard] Update text in Medical Records subsection (in the Supporting Information section) based on various logic[#19786](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19786) (In Progress) - [Discharge Upgrade Wizard] Update Buddy Statement text per CAIA content update document [#19787] ((https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19787) (In Code Review) #### Not required, but nice to have artifacts - [X] **Content source of truth**: link to CAIA Content feedback, such as a [content source of truth](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/issues/1981). - [N/A] **Information Architecture spec**: link to CAIA IA feedback, such as an IA spec. ##### Platform actions - [x] [Slack thread with VFS team](https://dsva.slack.com/archives/C52CL1PKQ/p1732334042324309) - [x] Meeting date/time: **Tuesday, December 3, 2024 at 3:30pm ET** #### After meeting ##### Platform actions - [ ] Update this ticket with the Zoom recording - Recording link - Password: ##### VFS actions - [ ] Review the findings tickets and comment on the ticket if there are any questions or concerns - [ ] Close individual findings tickets when the issue has been resolved or validated by your Product Owner. If a team has additional questions or needs Platform help validating the issue, please comment on the issue ticket. - [ ] After launch, [request an accessibility audit from the VA 508 Office](https://depo-platform-documentation.scrollhelp.site/developer-docs/request-support-from-the-va-508-office#RequestsupportfromtheVA508office-AuditRequest). This is required even if no accessibility issues were found during the Staging Review. - [ ] Share ServiceNow ticket number here: ______ - [ ] Close ticket once Privacy, Security, Infrastructure Readiness Review has been completed, VA 508 Office audit is requested, and all other post-Staging actions are complete

Privacy, Security, Infrastructure Readiness Review πŸ‘‰πŸ½ Passed

Toggle Privacy, Security, Infrastructure Readiness Review #### VFS actions - [X] Complete the [Privacy, security, infrastructure readiness review process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Privacy-and-security-review.1782317101.html) - [X] Link to the Readiness Review ticket below - https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/issues/1981 #### Platform actions - [ ] Privacy, security, infrastructure readiness review is complete
jilladams commented 7 months ago

@FranECross @aklausmeier (cc @thejordanwood) Discharge Upgrade Wizard collab cycle ticket here is recommending some touchpoints we need to figure out / maybe talk to Governance folks about:

  1. Design Intent: We're using the DS subtask pattern the same way we did for Income Limits and PACT Act wizards, and we don't have a design artifact other than our user flow for that reason. So: we likely need to talk to Governance folks about what's required here from their perspective.
  2. Research review: Same. We aren't currently planning to run research, because we're moving from a deprecated pattern to a DS pattern.
  3. Midpoint: Same. We won't have any additional artifacts for this touchpoint. I think we might be able to propose skipping Design Intent and Research Review, and jump right to requesting an async Midpoint.

Thoughts?

FranECross commented 7 months ago

@coforma-terry I'm not sure how or who to approach regarding Jill's points above. Would I just note things in the ticket in the appropriate sections as to why we believe that particular review wouldn't be relevant/the info we have would be sufficient, and then do the async when I request a midpoint review? Thanks in advance for your guidance!

jilladams commented 6 months ago

@shiragoodman ^^ These might also be questions for you.

shiragoodman commented 6 months ago

@FranECross @jilladams Both the Design Intent and Midpoint Review are optional touchpoints, so if you'd like to skip them for any reason, you're welcome to. The Research Review is only required if you're planning to do research with Veterans or if you're doing any experimental design. We won't allow proposed component changes/uses to be published to VA.gov unless the solution has been tested. LMK if you have any other questions.

FranECross commented 1 month ago

@shiragoodman Regarding the Architecture Intent touchpoint needed for Discharge Upgrade Wizard, can someone please add that to the ticket so I ensure I have all that's required for it? BTW I have the checklist from Matt already and am preparing that info, but just want to ensure all tasks are ticked off as needed. Thanks in advance!

jilladams commented 1 month ago

Because Zenhub is likely going away, Sitewide may hit our Github Projects issue cap (1200), and may not be able to port all our issues in right away, logging which issues in this ZH epic are still open, so we can later build parent/child relationships in GHP as needed. I'll update this comment through EOY with any new tix that arise from Collab Cycle, or until we get migrated into GHP fully.

shiragoodman commented 1 month ago

@FranECross Architecture Intent has been added.

DonMcCaugheyUSDS commented 3 weeks ago

Architecture Intent Meeting results:

Strong recommendation:

Also consider:

FranECross commented 3 weeks ago

Architecture Intent Meeting results:

Strong recommendation:

  • use a timer to clear the state of the wizard after a reasonable period of inactivity (suggest 5 minutes)

Also consider:

  • add Cypress tests to check external site links

@DonMcCaugheyUSDS Do you mind adding your feedback, etc. to the Architecture Intent section, so folks will know at a glance the outcome and our next steps? Thanks in advance!

Image