department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 201 forks source link

[FE] 10-10EZR TERA Questions: Work with Platform Team to fix V3 Components bug #80889

Open alexseelig opened 5 months ago

alexseelig commented 5 months ago

As a Veteran, I would like to answer the TERA questions on EZR with a UI that is modern, up to date, and easy to use so that I can apply for the healthcare I have earned.

mkerns1 commented 5 months ago

Per Robert's proposed solution:

image.png
allanto-ah commented 5 months ago

Environment: Review instance

Issue 1: The questions on the TERA sections in the review instance are bolded while on staging it isn't. See screenshot below - the page on the left is the review instance and the screenshot on the right is staging

Screenshot 2024-05-09 at 7.40.33 AM.png
allanto-ah commented 5 months ago

Environment: Review instance

Issue 2: The "(*Required)" tag is missing on the first TERA question asking users if they want to provide TERA information. See attached screenshot - Review instance is the left page and staging is on the right page

Screenshot 2024-05-09 at 7.40.05 AM.png
allanto-ah commented 5 months ago

Environment: Review instance

Issue 3: On the confirmation page, the review instance isn't showing the corresponding TERA questions. See screenshot below - Review instance is on the left of the screenshot and staging is on the right

Screenshot 2024-05-09 at 7.41.48 AM.png
mkerns1 commented 4 months ago

Priority shift to ticket #80851

Update: Ticket 80851 is closed. Shifting priority back to this ticket.

mkerns1 commented 4 months ago

Environment: Development

Issue 1:

image.png

Issue 2:

image.png

Issue 3:

image.png
mkerns1 commented 4 months ago

Analysis: Justification for Foregoing TERA Component Updates to v3

Overview

During the recent Engineering Sync, the team discussed the ongoing issues related to updating the TERA components to v3 in the EZR form. This analysis provides a detailed justification for the decision to forego these updates and leave the EZR TERA section in its current state until the Forms System Team resolves the issues with the yesNoUI component, which functioned correctly before the v3 update.

Key Feedback Points

  1. Stability and Functionality of the Current System

    • The existing yesNoUI component in its pre-v3 state has been stable and functionally sufficient for the requirements of the EZR form. Engineers highlighted that this component adequately handled user interactions and conditional logic without issues.
    • Our decision is that it is advisable to maintain the current implementation, as it is stable and functioning effectively. Introducing the v3 update has led to instability and unpredictable behavior in the conditional logic, particularly when selecting "No" in the radio component.
  2. Current Issues with v3 Update

    • The v3 update of the yesNoUI component has introduced significant issues, specifically with the handling of conditional logic. When users select "No" in the radio component, the expected behavior of skipping the subsequent page is not being executed correctly.
    • The engineering team has spent considerable time troubleshooting these issues without a satisfactory resolution. This has led to delays and inefficiencies in the development process, impacting the overall project timeline.
  3. Dependency on Forms System Team

    • The yesNoUI component's issues are tied to the core functionality provided by the Forms System Team. The engineering team does not have direct control over these core components and must rely on the Forms System Team to implement the necessary fixes.
    • Until the Forms System Team addresses these issues, any attempt to update the TERA components to v3 is likely to result in continued instability and user experience problems.
  4. Impact on User Experience

    • Maintaining a consistent and predictable user experience is the goal. The current implementation of the TERA section in the EZ form has proven to be user-friendly and reliable. Any changes that introduce bugs or inconsistencies will negatively impact users, potentially leading to frustration and decreased trust in the system.
    • By foregoing the v3 updates, we ensure that users continue to have a seamless experience when interacting with the TERA section.
  5. Project Prioritization and Resource Allocation

    • Given the limited resources and the need to prioritize critical updates and features, it is best to allocate engineering efforts toward areas with a higher impact on user experience and overall system functionality.
    • Waiting for the Forms System Team to resolve the yesNoUI issues allows the engineering team to focus on other pressing tasks and enhancements that can drive more value to the project in the short term.

Conclusion

Based on the feedback and the outlined justifications, it is clear that updating the TERA components to v3 at this stage would introduce more risks and challenges than benefits. By maintaining the current implementation of the TERA section in the EZR form, we ensure stability and a positive user experience. This decision allows the engineering team to allocate resources more effectively and avoid unnecessary complications until the Forms System Team resolves the issues with the yesNoUI component.