search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[ARF] - Update feature toggle to use the logged in user as the actor #81084

Closed cohnjesse closed 1 month ago

cohnjesse commented 6 months ago

Background

We added a feature toggle for our pilot rollout however it is simply a general feature toggle that can either be on for everyone or off for everyone. Since we have not started the pilot rollout we have it turned off for everyone however in order for us to allow specific users to be enabled in the feature toggle we need to enable it in the code once the sign-in work is closer to complete.

Update this code inside /Users/jessecohn/Desktop/ks442/vets-api/modules/accredited_representative_portal/app/controllers/accredited_representative_portal/application_controller.rb

if Flipper.enabled?(:accredited_representative_portal_pilot)

to be

if Flipper.enabled?(:accredited_representative_portal_pilot, current_user)

Acceptance criteria

gabezurita commented 6 months ago

This is a duplicate of the allowlisting issue: https://app.zenhub.com/workspaces/accredited-representative-facing-team-65453a97a9cc36069a2ad1d6/issues/gh/department-of-veterans-affairs/va.gov-team/80613

The AC in this ticket has already been completed.

See PR: https://github.com/department-of-veterans-affairs/vets-api/pull/16382

cc @a6marinos