Remove feature toggle code from NoK/EC

wesrowe commented 6 months ago

Description

User story

As a Cartography team member, I want to remove feature toggle and logic from the NoK/EC code, so that the code is simpler for future dev and maintenance.

Notes

Prereq: feature has been at 100% of users for 2 weeks. (Went to 50% on 4/22/24)
https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/identity-personalization/profile/personal-health-care-contacts/release-plan/release-plan-mvp-mar-2024.md

Tasks:

[x] Remove feature toggle from vets-api
[x] Remove feature toggle from vets-website
[x] Merge changes and wait for changes to propagate to envs.
[x] Run Flipper.remove(:profile_contacts) in development (dev-api.va.gov).
[x] Run Flipper.remove(:profile_contacts) in staging (staging-api.va.gov)
[x] Run Flipper.remove(:profile_contacts) in sandbox (sandbox-api.va.gov
[x] Run Flipper.remove(:profile_contacts) in production (api.va.gov)

Acceptance criteria

The steps for removing a feature toggle from vets-api and vets-website have been completed
Feature toggle and associated code removed from vets-api and vets-website repositories

radavis commented 3 months ago

To verify that the feature toggle has been removed, visit {dev-,sandbox-,staging-,_}api.va.gov/flipper, press CTRL+F (CMD+F) and search for profile_contacts. No results should be displayed.

To verify the feature is still enabled, log in with one of the following accounts, and then navigate to /profile/contacts.

allanto-ah commented 3 months ago

@radavis I still see this feature toggle in the production environment, api.va.gov. Is this expected?

radavis commented 3 months ago

@allanto-ah, This is definitely not expected behavior. I filed a support request for this issue as it seems there's something happening that is adding profile_contacts and mhv_landing_page_enabled feature toggles to the database after it has been removed from the codebase and database.

radavis commented 3 months ago

Blocked by department-of-veterans-affairs/va.gov-team#88088

allanto-ah commented 3 months ago

@radavis

The feature toggle is still showing in production environment, api.va.gov

wesrowe commented 3 months ago

Friends, I seem to recall that in 2023 my team tried to remove a bunch of feature flags and ran into this same problem. I would advise asking Platform whether this is a known issue.

allanto-ah commented 3 months ago

@wesrowe Yeah, Richard has already reached out to Platform in regards to these: link. It seems to be something that works sometimes and not all the time. He was able to get it to work for 81709, but seems like it didn't work for this one.

radavis commented 3 months ago

Looks like I missed a line...

department-of-veterans-affairs/vets-website#30949 removes profile_contacts toggle from featureFlagNames.json

carlosfelix2 commented 2 months ago

Checked and the profile_contacts toggle has been remove from staging and prod.

allanto-ah commented 2 months ago

Environment: Staging, Production

Verified that the EC/NoK is still being shown as expected. No regression issues.

department-of-veterans-affairs / va.gov-team