department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 198 forks source link

Verify all form validation and conditional page logic #81359

Closed michaelclement closed 1 month ago

michaelclement commented 5 months ago

Form 10-7959c's flow is now complete (from a structure standpoint, not content-wise), so this ticket is a QA/polish/bug finding ticket. There are several conditional page triggers and lots of form pages with special validation needs, so the goal here is to verify that the form behaves as expected and that users aren't confronted with vague errors or difficulties submitting.

Figma link

Acceptance criteria

michaelclement commented 1 month ago

Spreadsheet of verified conditionals here, spreadsheet of verified inputs - (see this issue)

michaelclement commented 1 month ago

Once this PR is merged this should be good to go. Only issue was on the confirmation page when required files were still missing. Had to update the alert from green to yellow per the Figma, and adjust some conditional wording.

michaelclement commented 1 month ago

@baltes @marywang2 - PR merged. To review, please see the above attached spreadsheets. Thanks!

baltes commented 1 month ago

One file linked above looks good. I don't have access to the other yet, but I'm closing this out to close the sprint. I'll still check back on this and reopen if any issues pop up.