department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
278 stars 194 forks source link

EVSS PCIU Migration: Step 2: Form VA21p530 - FormProfile and FormProfile Spec #81364

Open RachalCassity opened 2 months ago

RachalCassity commented 2 months ago

VAProfile::Configuration::SETTINGS.prefill is set to true. PCIU data should no longer be used.

FormData.initialize_contact_informationprefills contact information with PCIU data.
Coverband is showing a lot of data. This will have to be tested when migrating to VAProfile. PCIU references need to be removed.

FormProfileSpec form data will need to be updated to use VAProfile data. PCIU data will be depreciated.

  def initialize_contact_information
    opt = {}
    opt.merge!(vets360_contact_info_hash) if vet360_contact_info
    opt[:address] ||= user_address_hash
    opt[:email] ||= extract_pciu_data(:pciu_email)
    if opt[:home_phone].nil?
      opt[:home_phone] = pciu_primary_phone
      opt[:us_phone] = pciu_us_phone
    end
    format_for_schema_compatibility(opt)
    FormContactInformation.new(opt)
  end

Tasks

RachalCassity commented 2 months ago

Blocked by teams that own forms calling FormProfile