search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Remove feature toggle: mhv_landing_page_enabled #81709

Closed radavis closed 3 months ago

radavis commented 6 months ago

Now that this feature toggle is at 100%, it can be removed.

VA Platform docs: Removing old/unused feature toggles

allanto-ah commented 3 months ago

@radavis I still see the feature toggle in the production environment, api.va.gov. Is this expected?

Screenshot 2024-07-09 at 8.26.58 AM.png
radavis commented 3 months ago

@allanto-ah That's strange because I was able to verify that it was removed in the following support request. I suppose I'll ask to have it removed, again...

https://github.com/department-of-veterans-affairs/va.gov-team/issues/87749

radavis commented 3 months ago

https://github.com/department-of-veterans-affairs/va.gov-team/issues/87912

Half-an-hour after removal, it's showing up in the flipper UI.

We've gone through the steps. The feature toggle is removed from the codebase, which can be verified by searching mhv_landing_page_enabled and mhvLandingPageEnabled in vets-website and vets-api. ~As for removing the feature toggle permanently from the production database, this is a higher-level problem that's not going to be solved as part of this ticket.~

Edit: Seems to be a timing issue. Best to wait at least a few days after merging code that removes a feature toggle to run Flipper.remove().

radavis commented 3 months ago

@allanto-ah This should be ready for QA, now.

allanto-ah commented 3 months ago

Verified that the feature toggle has been removed from api.va.gov. Also verified that MHV landing page is working as expected