department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
275 stars 193 forks source link

Adopt Sidekiq guidelines for the Pension application #81989

Closed aplatt-coforma closed 2 weeks ago

aplatt-coforma commented 1 month ago

Steve Albers wrote up an Architectural Decision Record addressing Sidekiq guidelines for the Benefits team. We should audit and update sidekiq jobs in Pension application to conform to the guidelines.

mjknight50 commented 3 weeks ago

Moving as @sanjabaj2 requested

scottsdevelopment commented 2 weeks ago

Sideqik Job Audit for Pensions Related Code.pdf

sanjabaj2 commented 2 weeks ago

Sideqik Job Audit for Pensions Related Code.pdf

For some reason I can't access the attachment. Get 404 error. I am not on VPN, if that makes any difference.

scottsdevelopment commented 2 weeks ago

Sideqik Job Audit for Pensions Related Code.pdf

sanjabaj2 commented 2 weeks ago

Sideqik Job Audit for Pensions Related Code.pdf

File Permission Denied Looks like you don't have access to this file, please ensure you are part of the Zenhub Organization that the file belongs to or contact your administrator.

aplatt-coforma commented 2 weeks ago

@sanjabaj2 - just uploaded to our Google Drive and shared the link with you. https://drive.google.com/file/d/1G4c1E4IVDmBS1CETxdoYwkxexw57MJ6t/view?usp=sharing

wayne-weibel commented 2 weeks ago

After discussion this morning, we will be creating 3 - 4 followup tickets to address the findings (none need immediate attention):

sanjabaj2 commented 2 weeks ago

Just added a comment to the Google doc regarding sidekiq jobs that we believe are not our responsibility. Do we know who those teams are? Can you add names to the document if you know it.

aplatt-coforma commented 1 week ago

Added links to the 4 followup tickets that the team created.

wayne-weibel commented 1 week ago

https://dsva.slack.com/archives/CTXGRFUNN/p1716306145434949