department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Landing page and secondary nav links handle new root font size #82433

Closed wesrowe closed 5 months ago

wesrowe commented 6 months ago

Description

User story

As a Cartography team member, I want to ensure that the updated root font sizes of the VADS don't change the size of fonts on the MHV landing page, so that Veterans' experience is unchanged.

Notes

Possible tasks:

Acceptance criteria

dcloud commented 6 months ago

We may also need to tweak rem values in Secondary Nav, as mentioned on department-of-veterans-affairs/vets-website/pull/29592

dcloud commented 6 months ago

Looks like the landing page changes exist in the big PR now: https://github.com/department-of-veterans-affairs/vets-website/pull/26606/files?show-viewed-files=true&file-filters%5B%5D=#diff-3eb65c1def06b4b948dd2d4ffc6cc930ec11fda40bd770611d62866f4b1e8c3c

Things under src/platform/mhv, e.g. Secondary Nav, appear uncoverted at this time

dcloud commented 6 months ago

Created a PR pointing to the bigger PR, and left a review comment asking for those minor changes

dcloud commented 6 months ago

The Secondary Nav changes are merged into the larger PR, department-of-veterans-affairs/vets-website/pull/26606, and I have review typography/spacing changes on that branch and things look good.

I think this is done as far as we are concerned, but I don't know the ETA for when the bigger PR will get merged

dcloud commented 5 months ago

The larger PR has been merged