Support alert assertions in VAOS unit tests

[JunTaoLuo]

Summary

• Tests involved
  • VAOS Page: TypeOfVisitPage - should not submit empty form
  • VAOS Page: ClosestCityStatePage - should not submit without choosing a site
• Issues or enhancements involving test infrastructure and libraries

Currently alerts from validation is difficult to write assertions for in certain unit tests since the DOM does not update after user action (e.g. clicking a button or choosing an option) is made. Ideally we should be able to assert alerts are displayed correctly to ensure the desired component behaviors.

Steps to Reproduce

• Enable the disabled assertions in the test that link to this issue and the test will fail

Actual Result

Currently these assertions are disabled so no errors are observed but enabling the assertions will result in the following stack traces:

Expand stack trace

``` 1) VAOS Page: ClosestCityStatePage should not submit without choosing a site: Unable to find role="alert"

We'll send your request to the VA medical center nearest to the city you select. The medical center staff will help schedule your community care appointment.

Back

Continue »

We'll send your request to the VA medical center nearest to the city you select. The medical center staff will help schedule your community care appointment.

Back

Continue »

Error: Unable to find role="alert"

We'll send your request to the VA medical center nearest to the city you select. The medical center staff will help schedule your community care appointment.

Back

Continue »

at waitForWrapper (node_modules/@testing-library/dom/dist/wait-for.js:173:27) at findByRole (node_modules/@testing-library/dom/dist/query-helpers.js:101:33) at _callee2$ (src/applications/vaos/tests/new-appointment/components/ClosestCityStatePage.unit.spec.js:75:25) at tryCatch (node_modules/regenerator-runtime/runtime.js:63:40) at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:294:22) at Generator.next (node_modules/regenerator-runtime/runtime.js:119:21) at asyncGeneratorStep (src/applications/vaos/tests/new-appointment/components/ClosestCityStatePage.unit.spec.js:19:103) at _next (src/applications/vaos/tests/new-appointment/components/ClosestCityStatePage.unit.spec.js:21:194) ```

Definition of Done

• [ ] Root cause for test failure is found
• [ ] Test is updated or fixed

[ldelacosta]

Assigning the ticket @JunTaoLuo and @simiadebowale for awareness. Please move it to the Ready queue when the team can start on the work. cc: @JRRoof