Staging Review finding: Confirm pattern for dependent children multi page pattern

shiragoodman commented 4 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Pension benefits Product: 527EZ Feature: Update multi-response (single page list loop) pattern

Findings details

VA.gov Experience Standard - issue: User encounters design components that are out of date. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: Yes Collab Cycle Reviewer: @allison0034 (Design), @erinrwhite (IA)

Description

I noticed the pattern you are using for dependent children is slightly different than what we have in the Design System which is slightly different than what we have in the forms library.

Recommended action

~~No recommendation right now. I need to get confirmation on what the exact pattern is and then I can update this ticket.~~ Follow the pattern we have in the Design System. Add Step 3: One the Veteran selects “Continue” they are moved onto a new screen with the message: “Now we’re going to ask you some follow-up questions about each of your [items]. We’ll go through them one by one.”

References

Accessibility Defect Severity: N/A
WCAG Success Criteria: N/A
Modality: N/A
Design System Component: N/A
Design System Pattern or Template: Multiple responses
Design System Foundation: N/A
Content Style Guide: N/A
Context: N/A

Next Steps for the VFS Team

[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members with any questions or to get help validating the issue.
[ ] Ticket ownership: If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag @platform-governance-team-members on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.
[ ] Close this ticket when the issue has been resolved or validated by your Product Owner.

allison0034 commented 4 months ago

@matt4su I have updated this ticket. You just need to add the missing step. Let me know if you have any questions.

danbrady commented 2 months ago

Figma file: https://www.figma.com/design/9JKK5Eo43uJWEr66JPiebc/Pension-Claim-Form-21P-527EZ?node-id=5132-46077&t=BkxIMm2hsm8YyJe1-1

Note: Additional questions appear if a dependent is 18-23 years old ("Are they in school?") and if they the dependent has been married ("Are they still married?"). These are also shown in the Figma link above. This behavior exists in the current live form as well.

cc: @aplatt-coforma @matt4su @TaiWilkin

aplatt-coforma commented 2 months ago

Thanks @danbrady for providing the update designs for implementation. Moving this to Product Backlog column for eng to work next sprint.

ToddWebDev commented 1 month ago

ToddWebDev commented 3 days ago

This issue can be unblocked and is ready for content and design review.

department-of-veterans-affairs / va.gov-team