[Design, PM] Design system updates: visual QA post-typography changes - Githubissues

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

282 stars 201 forks source link

[Design, PM] Design system updates: visual QA post-typography changes #83635

Closed ajakabcin closed 2 months ago

ajakabcin commented 4 months ago

Background

Design system will be making updates to typography as follows:

5/22: root change change from 10px -> 16px (we need to do visual QA)
6/5: base font size increases from 16px ->16.96px (we need to do visual QA starting 5/22 for 1 sprint)

We need to perform visual QA of My VA to ensure everything looks ok.

Tasks

[x] Perform visual QA of My VA
[x] Identify any issues with changes in typography and report them to Design System
[x] If changes are need to My VA code, work with PM to identify needs

Acceptance Criteria

We know the impact of the typography changes

mattmarino-adhoc commented 3 months ago

Appears that it is still 16px for My VA on Staging (user 23), let's discuss on June 10th @allisonlu

Screenshot 2024-06-06 at 10.00.55 AM.png