10-7959c: update copy - File upload section

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

283 stars 204 forks source link

10-7959c: update copy - File upload section #83950

Closed marywang2 closed 4 months ago

marywang2 commented 5 months ago

As a user on VA.gov, I want to provide supporting documentation when filling out the OHI form so that I can report any changes to my other health insurance.

Page elements:

breadcrumb
header and subhead
progress indicator
footer

Pages (following secondary insurance questions):

upload supporting documents (upload medicare card link, upload health insurance card link)
- if file is uploaded, then show success state
- if outstanding documents, then show supporting document summary (supporting document acknowledgement checkbox)

Figma link ("Prep for staging review"): https://www.figma.com/design/sSPoS7R9HE6ZlxRESRy2ms/10-7959c-Form?node-id=1155-73969&t=Y8cWvTGeyw2lKO6X-0

Acceptance criteria:

Given the user is on VA.gov and is filling out the OHI form
When the user gets to the file upload section
Then the user can include their supporting documents as part of the other health insurance certification submission

michaelclement commented 5 months ago

Work is done here - waiting on:

[x] Team approval
[x] Platform approval

michaelclement commented 5 months ago

@marywang2 This is ready for you to take a look at on staging. Thanks!

marywang2 commented 5 months ago

@michaelclement the figma was updated to reflect the different files that may need to be uploaded. Some more changes/questions below:

Can you populate the health insurance's name in the upload links?
Remove Parts A and B from the medicare insurance bullets
Remove "Primary" and "Secondary" from the health insurance bullets
Can you increase the margin in between the links and by by 8px?
Remove user's last name (use first name only)

michaelclement commented 4 months ago

@marywang2 These changes have now all been implemented in this PR

Screenshots attached on GitHub - thanks!

marywang2 commented 4 months ago

@michaelclement I removed the front/back logic comment (forgot I had put it in there). Let's discuss....

michaelclement commented 4 months ago

(Plan is to discuss in a parking lot after huddle today 6/17)

michaelclement commented 4 months ago

Currently waiting on the final agreement from other designers ( @jamiefiore ), but it seems like requiring the user to upload multiple documents on screens where we want front/back is an acceptable solution.

michaelclement commented 4 months ago

@marywang2 Jamie confirmed designers were satisfied with this solution, so you should be able to check this out on staging whenever you have time. Thanks!