department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

10-7959c: update copy - Signature #83952

Closed marywang2 closed 4 months ago

marywang2 commented 5 months ago

As a user on VA.gov, I want to be able to sign when filling out the OHI form so that I can certify any changes to my other health insurance.

Page elements:

Pages (following file upload screen):

Figma link ("Prep for staging review"): https://www.figma.com/design/sSPoS7R9HE6ZlxRESRy2ms/10-7959c-Form?node-id=1155-73969&t=Y8cWvTGeyw2lKO6X-0

Acceptance criteria:

michaelclement commented 5 months ago

Work is done in these two PRs (frontend and backend). Waiting on:

michaelclement commented 4 months ago

Screenshots are attached to the Github ticket, but adding them here as well:

s1.png s2.png
marywang2 commented 4 months ago

@michaelclement there were some very recent updates to the [figma] copy (https://www.figma.com/design/sSPoS7R9HE6ZlxRESRy2ms/Other-Health-Insurance-Certification-(10-7959c)-Form?node-id=1155-73969&t=8jkV7WpYOH4EiGtC-0) - this will be reviewed in Monday's design meeting so please pause on any changes until after the meeting. Thanks!

michaelclement commented 4 months ago

@marywang2 This should be ready for review. Thanks!

michaelclement commented 4 months ago

Final wording change is in this PR (merged) and not on staging yet, but it only impacts one bullet point:

340477367-380e87f7-ed22-4040-91cc-9c1aa2dd2f84.png
marywang2 commented 4 months ago

@michaelclement putting this on pause for now until we can incorporate the latest copy updates from CAIA into the figma. cc @jamiefiore

michaelclement commented 4 months ago

Latest work is here in this PR.

Waiting on:

before after
signer info before.png after.png
signature block b1.png b2.png

@jamiefiore Just want to bring your attention to the "on behalf of" portion - there's no good way to add content between the signature field and the checkbox, so I had to add this text above those. This is a limitation of the standard signature block. I could make a completely custom one to get around this, but that would extend the amount of code by about another ~150 lines. If we feel that's a trade-off that's worth it I can do that, but I don't know that it is. Just want to toss it out there. Thanks!

michaelclement commented 4 months ago

@baltes @marywang2 @jamiefiore Merged and should be visible on staging shortly - thanks!

baltes commented 4 months ago

LGTM. @jamiefiore Could you take a look and confirm?

jamiefiore commented 4 months ago

@baltes @michaelclement Design wise it looks great. I noticed that a error message pops up really quick before moving to the confirmation page when a third party signs the Statement of Truth though

michaelclement commented 4 months ago

Thanks @jamiefiore! - let me look into that error and follow up here in a bit. We may want to split that into a separate ticket.

michaelclement commented 4 months ago

@baltes @jamiefiore I looked into this a bit more and I think it warrants a separate bug ticket. I've created that here. If that works for y'all, I'd recommend closing this one out. Thanks!