department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Add link to MHV landing page #84282

Open kjduensing opened 3 months ago

kjduensing commented 3 months ago

Description

It was determined from research that the most likely place Veterans would look for travel claims status is the MHV landing page. We need to add a link so that Veterans can access their travel claims summaries.

image

Acceptance Criteria

Demo

Definition of Done

kjduensing commented 3 months ago

@micahtaylor or @carafrissell1 can you please link to the designs or verbiage for the status page link on the MHV travel page?

micahtaylor commented 3 months ago

Check travel reimbursement claim status

Screenshot 2024-05-30 at 1 58 46 PM

kjduensing commented 3 months ago

@ayush-chak I could use another opinion on this:

Context: The way the MHV landing page code is written doesn't easily allow for feature toggles to be incorporated. Ideally, that's what we'd do: add a feature toggle around the status page link on the MHV landing page.

Mitigation:

  1. We deploy to prod
  2. We give friends/family testers a direct link to the status page
  3. Once it's confirmed working in prod, we write the (very) simple code to add the link and deploy it

Pros: It's easy (fast) and neighborly (doesn't change a lot of others' code). Cons: If we had to disable the feature flag, the link would be there until a deploy went out, but the functionality would not. In most cases this should be fine since the important part (functionality) would be turned off.

Could you let me know your thoughts please?

kjduensing commented 3 months ago

What that ^^ means for the ticket is that it goes back into the backlog and added to the Prod Deploy Steps epic

kjduensing commented 3 months ago

Something I didn't think about initially is that based on our feature flag, if we can't also incorporate the feature flag into the MHV landing page links, all logged in users will see the MHV link, but only some logged in users will be able to access the status page.

kjduensing commented 3 months ago

I asked an MHV engineer how we might do this.

ayush-chak commented 3 weeks ago

Holding for friends and family rollout before implementing