Remove "new tab" text/behavior from VA-subdomain links

sterkenburgsara commented 1 month ago

Is this blocked?: Sara working with team that wants to add a second link to a BTSSS-on-VA.gov status page

Description

VADS updated external link guidance a day after we implemented the last update this link. Sorry! I don't think this is pressing, but external link guidance now states that external links should not open in a new tab.

User story

As a Cartography team member, I want to update the BTSSS link on the My HealtheVet home page so that it no longer opens in a new tab (or indicates that it will do this), so that I am complying with the latest VADS guidance for external links.

NOTE: checked in with Patrick in comments below re whether to make this change.

Notes

Possible tasks:

[ ] Update the link under payments that reads "File a claim for travel reimbursement....." by removing the parenthetical text that says (opens in new tab)
[ ] Update link behavior to no longer open in a new tab. Should now open in the same tab.

Acceptance criteria

[ ] BTSSS link now opens in same tab & link text has been updated

wesrowe commented 1 month ago

@sterkenburgsara – I updated the title. Can you confirm whether we need to make this update to the newsletter subscription link also?

sterkenburgsara commented 1 month ago

I thought we couldn’t do the newsletter link in a new tab bc of security reasons with GovDelivery on public computers or something? That came from Patrick, can you possibly check with him? I think if that’s the case an exception for that link is likely fine.

On Fri, May 31, 2024 at 18:24 Wes Rowe @.***> wrote:

@sterkenburgsara https://github.com/sterkenburgsara – I updated the title. Can you confirm whether we need to make this update to the newsletter subscription link also?

— Reply to this email directly, view it on GitHub https://github.com/department-of-veterans-affairs/va.gov-team/issues/84339#issuecomment-2143104754, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3NULPCIGNNND5RZNDXP5MLZFEBBZAVCNFSM6AAAAABITCD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGEYDINZVGQ . You are receiving this because you were mentioned.Message ID: @.*** .com>

wesrowe commented 1 month ago

@sterkenburgsara, you're totally right, that slipped my mind. Do you have a link to the new guidance? The link I found didn't seem to cover why a link would open in a new tab (the heart of the change).

Now that you reminded me of the security concern, I wonder if the Why of the rule has really changed? I'll investigate.

wesrowe commented 1 month ago

Neither of the links that are being referenced in "changed guidance" posts says much that sounds different from the status quo.

external links guidance just talks about clarity
content guide has the thing about VA links open in new tab only if data loss is possible

Fran Cross (from Public Websites) shared an additional link to the VA subdomains that Drupal will no longer update in new tabs:

'myhealth.va.gov', 'ebenefits.va.gov', 'www.accesstocare.va.gov', 'www.gibill.va.gov/wave', 'www.blogs.va.gov', 'www.data.va.gov', 'mobile.va.gov', 'www.accesstocare.va.gov', 'www.oit.va.gov', 'ethics.va.gov',

So @sterkenburgsara, I think you're right about GovDelivery being a new-tab domain still, due to security concerns.

I wonder about BTSSS, using that same security lens. I believe VA.gov authentication carries over to BTSSS, so a Veteran on MHV Home will deep link straight into BTSSS. But can they also log out from there and have it end their session on VA.gov? @batemapf, do you know the answer to that question?

department-of-veterans-affairs / va.gov-team