department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 196 forks source link

Toxic Exposure - Form 21-526EZ PDF as a supporting document - polling for status job implementation #84389

Closed mchae-nava closed 1 week ago

mchae-nava commented 1 month ago

Story

As a steward of the Form 21-526EZ workflow, I would like to know the status of the Form 526 PDF submission to the eFolder when going through the primary path.

Goal:

We need a method to inform the vets-api system of the status of the Form 526 PDF as a supporting document of the established claim.

Link to notes and proposed options for implementation: https://dsva.slack.com/archives/C04KW0B46N5/p1717516393733889?thread_ts=1717516384.179439&cid=C04KW0B46N5

Summary:

  1. The job feasibly exists as a manual command that kicks off polling (not called automatically to start)
    • Including a playbook for running and comments in the job itself
    • Include a remediation plan
    • Should be the first step anyways to test
  2. Implement metrics Can be done concurrently with 1, 2, or 3

Context:

With the migration to the Lighthouse synchronous submit endpoint, Lighthouse returns the response after a claim is established and returns a claim id from VBMS representing the established claim. However, this does not ensure that the Form 526 PDF that was generated in the process got submitted along with the claim being established. If we were to utilize the Lighthouse synchronous submit endpoint, we would not know if the generated Form 526 PDF made it into the eFolder for the Veteran in VBMS.

Tasks

Acceptance Criteria

Out of scope

mchae-nava commented 1 month ago

Link to notes and proposed options for implementation: https://dsva.slack.com/archives/C04KW0B46N5/p1717516393733889?thread_ts=1717516384.179439&cid=C04KW0B46N5

aurora-a-k-a-lightning commented 1 month ago

notes:

sethdarragile6 commented 3 weeks ago

PR under review, just waiting on final approvals to auto-merge. Remediation plan and scripts are still in-progress @alatempa24 @pacerwow

sethdarragile6 commented 3 weeks ago

PR merged to main and deployed to staging, where it is currently being tested. Because there are a plethora of submission that have either a) failed with a non-retryable error (rows 3-5) or b) are so old that their claims have already been cleared out (rows 1-2), this makes it easy to test for the exhaustion scenario- with the catch that we still have to wait 48 hours before we see the job status set to 'pdf_not_found'.

Screenshot 2024-07-03 152213.png

The below job status record was the result of running the job for a more recent and successful submission

Screenshot 2024-07-03 150623.png

Come Friday afternoon, we should know whether or not the exhaustion scenario was successful or not!

sethdarragile6 commented 2 weeks ago

Successful stage test of the 48.hour limit being reached

image.png
alatempa24 commented 1 week ago

How will we get this into the upload? We need to reach out to Carbs for manual uploading of the file.