department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Add "Prepare for your appointment" section to in-person appointments #85118

Closed AdamOye closed 4 months ago

AdamOye commented 6 months ago

Issue Description

Add a "prepare for your appointment" section to in-person and phone appointments. These appointment types do not include the "how to set up your device" instructions for video appointments.

Acceptance Criteria








Design

Mockups

ldelacosta commented 4 months ago

Validated in staging. UX team will do a second review. cc: @outerpress

outerpress commented 4 months ago

@JunTaoLuo @ldelacosta a couple of issues, looking at Judy's appointments:

I'm fine if it'd be easier to deal with these in new tickets after this is released.

Screenshot 2024-07-29 at 3.13.58 PM.png
ldelacosta commented 4 months ago

Since this work is sitting behind a feature toggle, lets open a new ticket to address the other items. cc: @outerpress

JunTaoLuo commented 4 months ago

Sounds good, but for the tickets that I still have in progress (video and CC) I'll try to incorporate these feedback items.

JunTaoLuo commented 4 months ago

@outerpress Just curious what the behavior should be for cancelled appointments in the past, I assume we don't display the section?

outerpress commented 4 months ago

Thanks @JunTaoLuo ! We don't display canceled appointments at all in the past list, so no need to consider that case

JunTaoLuo commented 4 months ago

Ah that makes sense. However I see that our logic is a little strange since we fetch cancelled past appointments and then filter it out. I might file a spike issue to see what's going on there.

ldelacosta commented 4 months ago

Closing out the ticket. Will address the items above in a new ticket. cc: @outerpress @JunTaoLuo

ldelacosta commented 4 months ago

Address the additional items in #89551