Open allison0034 opened 4 weeks ago
@allison0034 no feedback or still populating?
Oh, sorry. I see it, doh.
@benbrasso-agile6 sorry, I got it in late today, I needed to confirm something with Matt. Just let me know if you have any questions.
Will leave this ticket open to work on the experimental ticket
@allison0034 I'd like to get an opinion on changes I've made to the filter page actions.
I received guidance from Sara Sterkenburg regarding the cancel action - making it a link rather than a button.
I would just make cancel a link in this case. Apply can be a button since it is saving data and navigating (same rules as "continue" buttons in forms).
With that in mind, I've come up with this as a solution (solving some of the visual issues with buttons on buttons on buttons). The left shows what we had previously. The right shows the updated design.
Hi @Cieramaddox , does "Cancel" navigate? Pulling in @briandeconinck since he will know best.
Depends on the definition of navigate. It does navigate the user back to the last screen, while it also cancels/stops that sub-task from being completed.
Ok, it may be something you want to actually walk @briandeconinck thru the flow.
I think a link is appropriate here. Sara hit the distinction exactly right: does clicking the element change user data? Button. Does it just move you to a different screen? Link. I believe the Veteran Facing Forms team has something in the works that will eventually follow that pattern with the forms library, with the Back button becoming a link.
Wonderful, thank you!
Next Steps for the VFS team
@platform-governance-team-members
.Thoughts/questions
-
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
Governance team actions