Closed briandeconinck closed 3 months ago
Sorry for the delayed feedback!
Just commenting here to say that all feedback has been addressed and implemented. We are not going to add the primer page before the uploads because we've switched the flow to only one claim at a time, so the entire process is much shorter now and less overwhelming
@marywang2 This ticket is complete and can be closed
Next Steps for the VFS team
@platform-governance-team-members
.Thoughts/questions
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
aria-live="polite"
to notify users of the change. I don't think that's strictly necessary here. The design system rules for conditionally revealing inputs should hopefully mitigate the need for anaria-live
region here, since it'll always be the next tab stop and it'll always be immediately relevant to what the user just did, and announcing it might be a little more verbose than we need. That said, if you find it tests better with actual humans when thearia-live
region is there, please report back! (And loop in Jeana Clark on the forms team too!)aria-describedby
. That's fine, but I'd encourage exploring using afieldset
/legend
pattern instead, eg.That pattern (1) avoids
aria-describedby
, which may be skipped for JAWS users who have personalized their verbosity settings, and (2) should ensure the helper text is announced once when tabbing into thefieldset
, as opposed to being added to the end of all of the inputs in thefieldset
. Not a must, but might be a pattern to try.Governance team actions