department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 196 forks source link

Claimant Type (Veteran vs. non-Veteran) #85623

Closed oddball-lindsay closed 1 week ago

oddball-lindsay commented 1 month ago

Issue Description

The Claimant Type page will be available to:

  1. Veteran and Non-Veteran users
  2. Authenticated users and unauthenticated users
  3. 21-22 and 21-22a forms

Content is not dynamic.

The claimant type will be used to guide the user flow, but does not route to any fields in the 21-22/21-22a forms.

URL: /claimant-type

Previous path: /introduction Next path: /representative-select

MVP Planning Mural

Designs

Prototype, Canvas, Annotations

Screenshots image.png image.png

Tasks

Acceptance Criteria

cosu419 commented 3 weeks ago

Assigning to @mtri for review

mtri commented 3 weeks ago

Other than that, looks good!

cosu419 commented 2 weeks ago

Thanks @mtri - wondering if you were drawing from any existing form apps as far as this screen goes? I ask because the default pattern seems to be that once the user passes the "Introduction" page, they have entered the tabbed form flow. So those pre-amble type screens (eg determining eligibility to fill out the form) typically happen before the Intro page.

If we do want to implement this as is, I suspect there are some workaround options available - just wanted to check whether it's been implemented somewhere before I explore further.

oddball-lindsay commented 2 weeks ago

@oddball-lindsay and @mtri will let Colin know if they find examples where there are questions after the intro page, but not yet part of a chapter.

cosu419 commented 2 weeks ago

This is ready for review @mtri - note that the size discrepancy between the buttons is a bug in the shared component. Will ask someone from the design system team about that.

image.png
mtri commented 1 week ago

Looks good!