department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

Payment History VBA Pre-MVP 1.0 - Implement page(s) #85887

Closed Tom-Davis closed 2 months ago

Tom-Davis commented 4 months ago

Description

This ticket covers the implementation of the Payment History page(s) for the VBA Pre-MVP 1.0. The implementation should reflect the design specifications and data mapping agreed upon in the previous review.

Given: The design and data mapping for the Payment History page(s) have been finalized When: A user navigates to the Payment History page Then: The user sees an accurately rendered page with correct debt details and transaction history Tasks

Acceptance criteria

Testing

Testing passed and documented in this ticket based on the "Then" statement in the description

Testing procedure:

HeatherRienks commented 3 months ago

The team met on 6/25/24 to discuss the scope of work needed to complete this effort. This is the only FE ticket and we will create one backend ticket to add dummy data to vets-api-mockdata (fake endpoint). We plan to add it to “ready” but will not pull into S128.

FYI @denisecoveyduc @Tom-Davis

OptionSelect commented 3 months ago

Per convo with Joe only show increases/decreases that are 0408 code!

OptionSelect commented 3 months ago

Draft PR created: https://github.com/department-of-veterans-affairs/vets-website/pull/30559

OptionSelect commented 3 months ago

Per convo with Aaron officially moved to blocked as we await completion of endpoint to slot real data request in place of dummy stuff. Also giving design an opportunity to style over our initial laydown!

HeatherRienks commented 3 months ago

FYI @josephrlee @mgleo Also, per last meeting on6/27 with DMC Team (Daniel Wildman, Pam Corbin-Jones), we are slated to receive the needed data in the coming week(s).

OptionSelect commented 3 months ago

Throwing the figmas in here just so I can keep track of em! https://www.figma.com/design/OiiDTTVTCf8j0GngRg0xxD/VA-Debt-Portal?node-id=359-9076&t=qw2BMUdtc6tSxRT6-0 https://www.figma.com/design/OiiDTTVTCf8j0GngRg0xxD/VA-Debt-Portal?node-id=139-14044&t=8lY9zUJQ5pcesCxc-0

mgleo commented 3 months ago

@OptionSelect Here's a direct link to the Figma art board for Payment History VBA Pre-MVP 1.0: https://www.figma.com/design/OiiDTTVTCf8j0GngRg0xxD/VA-Debt-Portal?node-id=1963-17591&t=nSZ4H50XWQXOybBy-1

You should see the annotations and you should see the title "Phase 1 MVP" above the mockups (if not it may not be the correct mock ups).

HeatherRienks commented 3 months ago

Per Pam Corbin-Jones, Daniel (DMC) has completed his work and they have slated SQA this week and will be done by end of next week (so, 7/12/24!)

OptionSelect commented 3 months ago

Still awaiting data from external team to replace mocked data we laid down to implement component.

OptionSelect commented 2 months ago

Now blocked until back end formats data into mocks for FE by https://app.zenhub.com/workspaces/vsa---debt-607736a6c8b7e2001084e3ab/issues/gh/department-of-veterans-affairs/va.gov-team/88596

OptionSelect commented 2 months ago

Joe left TODO's around to be removed in this effort as well.

HeatherRienks commented 2 months ago

@maxx1128 - please let @OptionSelect know when your efforts are completed- he is blocked until then!

cc: @Tom-Davis @alatempa24

OptionSelect commented 2 months ago

Per convo with Heather we are closing this ticket and creating a new one for the final implementation and TODO removal.