[FE] My VA C&A: Review logic for how claims and appeals statuses are rendered

[ajakabcin]

Background

We received an inquiry via slack as to how we are treating disability benefit claims in claim received status. There seems to be conflicting information though in terms of how we handle claims (where we use the phrasing received on date) vs an appeal (where we seem to be using the phrase submitted on date). We need to first nail down exactly how we're handling the display for claims and appeals independently and then determine how or if the logic needs to be divided.

Tasks

• [x] Investigate in the code how we are handling claims in claim received status
• [x] Investigate in the code how we are handling appeals in the equivalent/similar status toclaim received(is there an "appeal received" or is claim used to refer to either in this case?)
• [ ] Confer with Jerek Shoemaker and Skyler Schain on CST team as needed for any assistance with how they are handling received status
• [ ] Meet with AJ and Matt to discuss findings and figure out next steps (i.e. if we need to make a change in our logic or content)

Acceptance Criteria

• We have a clear understanding of how claims and appeals are handled in the 'received` status
• If required, we know what needs to be changed in our code or content

[allisonlu]

I created a Claims and appeals markdown file under engineering-docs, which i hope will be more evergreen than the comprehensive docs that Angela wrote up from 2022. I was thinking maybe I can start migrating some of these to the new folder.

To answer the question in this ticket:

claim received

Date received

This hard-coded copy is handled in lines 47–49 in the Claim component:

<h3 className="vads-u-margin-top--0">
  {capitalizeFirstLetter(getClaimType(claim))} claim received {dateRecd}
</h3>

---

appeal updated/submitted

Updated date

This hard-coded copy is handled in line 80 in the Appeal component:

 appealTitle += ` updated on ${format(
    new Date(replace(updatedEventDateString)),
    'MMMM d, yyyy',
  )}`;

Submitted date

This hard-coded copy is handled in line 107 in the Appeal component:

<p className="vads-u-margin-y--0">
  Submitted on:{' '}
  {format(
    new Date(requestEvent.date.replace(/-/g, '/')),
    'MMMM d, yyyy',
  )}
</p>

[ACParker89]

@ariperez can you take a look at this?

[ajakabcin]

thank you for this @allisonlu I'm going to roll to next sprint so we can discuss with @mattmarino-adhoc if we should be changing the appeals "submitted" date to align with how we refer to claims "received" date.

Also bringing down to a 1 - if we decide to make a change to the appeals dates that'll be a separate ticket.