department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

A11y improvements to 404 page #86053

Closed sterkenburgsara closed 2 months ago

sterkenburgsara commented 2 months ago

Description

In a previous ticket, Carlos flagged a title tag issue with the Drupal & React 404 pages and suggested making an improvement to the React version. As the team inspected that, we realized that the title of the 404 page "Sorry -- we can't find that page" has incorrect heading hierarchy and was an H3, not an H1. The title tag also did not match this title semantically. Those issues were fixed in ticket #85960.

To surface any remaining a11y issues, we filed a ticket with CAIA and one of their accessibility SMEs took a look and sent follow-on comments for what we should do to enhance the a11y of the page. This additional improvements should be solved by this ticket.

User story

As a Cartography team member, I want our 404 page to meet accessibility requirements so that it can effectively serve all Veterans.

As a Veteran, I want to know when I reach a page that is not found, and have the page title, title tag, and the page content all communicate this clearly to me so that I can recover from the error and take next steps to accomplish my task.

Notes

Possible tasks:

Acceptance criteria

laflannery commented 2 months ago

@sterkenburgsara The one update I might make to this ticket is regarding this AC:

Design system team ticket has been filed to get same changes made to the Drupal instance

I do not believe the DS owns the 404 page, I believe we do (Sitewide) so I'm not sure you would need to file a DS ticket. I will confirm this and get back to you though

fmccaf1 commented 2 months ago

Updated design linked here

For now, these designs are living in our (Cartography team)'s Figma file. At any point we can move over to CAIA's files, just let me know where is the best location.

fmccaf1 commented 2 months ago

I also just updated the experimental design ticket to reflect updated design.

sterkenburgsara commented 2 months ago

Update: @fmccaf1 presented the React design to DSC today 6/27/2024. They agreed the Design System Team should govern the 404 and that our recommendations should be accepted and also assumed by the Drupal version for single 404 design cohesion across the site. However, they asked us to align as closely with the USWDS 404 design as possible instead of continuing with the current design. In light of that, closing this ticket and creating a follow-on ticket that better captures that ask for the team's backlog.